Return-Path: X-Original-To: apmail-maven-issues-archive@minotaur.apache.org Delivered-To: apmail-maven-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5B09519804 for ; Sun, 24 Apr 2016 11:22:13 +0000 (UTC) Received: (qmail 54787 invoked by uid 500); 24 Apr 2016 11:22:13 -0000 Delivered-To: apmail-maven-issues-archive@maven.apache.org Received: (qmail 54734 invoked by uid 500); 24 Apr 2016 11:22:13 -0000 Mailing-List: contact issues-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list issues@maven.apache.org Received: (qmail 54723 invoked by uid 99); 24 Apr 2016 11:22:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 24 Apr 2016 11:22:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id E8BD22C1F54 for ; Sun, 24 Apr 2016 11:22:12 +0000 (UTC) Date: Sun, 24 Apr 2016 11:22:12 +0000 (UTC) From: "Karl Heinz Marbaise (JIRA)" To: issues@maven.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MWAR-376) Remove param properties that doesn't make sense for CLI usage MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MWAR-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255560#comment-15255560 ] Karl Heinz Marbaise commented on MWAR-376: ------------------------------------------ Remove the following: * {{resourceEncoding}} cause it's defined by the current project so no need to define it different via CLI * {{primaryArtifact}} * {{archiveClasses}} make a separate jar file of the classes yes? And why activating this on CLI but not in the configuration? > Remove param properties that doesn't make sense for CLI usage > ------------------------------------------------------------- > > Key: MWAR-376 > URL: https://issues.apache.org/jira/browse/MWAR-376 > Project: Maven WAR Plugin > Issue Type: Improvement > Affects Versions: 2.6 > Environment: n/a > Reporter: Anders Hammar > Fix For: 3.0.0 > > > Currently the plugin supports configuring several of the parameters via CLI properties. This doesn't make sense in many cases and encourages bad Maven usage (builds should be reproducible). Remove the properties for those parameters. The v3.0.0 release is a good time to do this. > First of all we need to identify candidates for removal. > This is the list of parameters/properties {{maven-war-plugin}} contains at the moment: > {noformat} > @Parameter( property = "archiveClasses", defaultValue = "false" ) > @Parameter( property = "resourceEncoding", defaultValue = "${project.build.sourceEncoding}" ) > @Parameter( property = "maven.war.webxml" ) > @Parameter( property = "maven.war.containerConfigXML" ) > @Parameter( property = "useCache", defaultValue = "false" ) > @Parameter( property = "maven.war.filteringDeploymentDescriptors", defaultValue = "false" ) > @Parameter( property = "maven.war.escapedBackslashesInFilePath", defaultValue = "false" ) > @Parameter( property = "maven.war.escapeString" ) > @Parameter( property = "maven.war.supportMultiLineFiltering", defaultValue = "false" ) > @Parameter( property = "maven.war.useJvmChmod", defaultValue = "true" ) > @Parameter( property = "primaryArtifact", defaultValue = "true" ) > @Parameter( property = "failOnMissingWebXml", defaultValue = "true" ) > @Parameter( property = "maven.war.skip", defaultValue = "false" ) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)