maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anders Hammar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MWAR-376) Remove param properties that doesn't make sense for CLI usage
Date Sun, 24 Apr 2016 11:27:12 GMT

    [ https://issues.apache.org/jira/browse/MWAR-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255562#comment-15255562
] 

Anders Hammar commented on MWAR-376:
------------------------------------

I think that we should remove close to all user properties. Anything that would alter the
resulting outcome (the war) shouldn't be possible to configure outside of the pom.

> Remove param properties that doesn't make sense for CLI usage
> -------------------------------------------------------------
>
>                 Key: MWAR-376
>                 URL: https://issues.apache.org/jira/browse/MWAR-376
>             Project: Maven WAR Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.6
>         Environment: n/a
>            Reporter: Anders Hammar
>             Fix For: 3.0.0
>
>
> Currently the plugin supports configuring several of the parameters via CLI properties.
This doesn't make sense in many cases and encourages bad Maven usage (builds should be reproducible).
Remove the properties for those parameters. The v3.0.0 release is a good time to do this.
> First of all we need to identify candidates for removal.
> This is the list of parameters/properties {{maven-war-plugin}} contains at the moment:
> {noformat}
> @Parameter( property = "archiveClasses", defaultValue = "false" )
>  @Parameter( property = "resourceEncoding", defaultValue = "${project.build.sourceEncoding}"
)
>  @Parameter( property = "maven.war.webxml" )
>  @Parameter( property = "maven.war.containerConfigXML" )
>  @Parameter( property = "useCache", defaultValue = "false" )
>  @Parameter( property = "maven.war.filteringDeploymentDescriptors", defaultValue = "false"
)
>  @Parameter( property = "maven.war.escapedBackslashesInFilePath", defaultValue = "false"
)
>  @Parameter( property = "maven.war.escapeString" )
>  @Parameter( property = "maven.war.supportMultiLineFiltering", defaultValue = "false"
)
>  @Parameter( property = "maven.war.useJvmChmod", defaultValue = "true" )
>  @Parameter( property = "primaryArtifact", defaultValue = "true" )
>  @Parameter( property = "failOnMissingWebXml", defaultValue = "true" )
>  @Parameter( property = "maven.war.skip", defaultValue = "false" )
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message