maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karl Heinz Marbaise (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MWAR-376) Remove param properties that doesn't make sense for CLI usage
Date Sun, 24 Apr 2016 11:22:12 GMT

    [ https://issues.apache.org/jira/browse/MWAR-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255560#comment-15255560
] 

Karl Heinz Marbaise commented on MWAR-376:
------------------------------------------

Remove the following:

 * {{resourceEncoding}} cause it's defined by the current project so no need to define it
different via CLI
 * {{primaryArtifact}}
 * {{archiveClasses}} make a separate jar file of the classes yes? And why activating this
on CLI but not in the configuration?

> Remove param properties that doesn't make sense for CLI usage
> -------------------------------------------------------------
>
>                 Key: MWAR-376
>                 URL: https://issues.apache.org/jira/browse/MWAR-376
>             Project: Maven WAR Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.6
>         Environment: n/a
>            Reporter: Anders Hammar
>             Fix For: 3.0.0
>
>
> Currently the plugin supports configuring several of the parameters via CLI properties.
This doesn't make sense in many cases and encourages bad Maven usage (builds should be reproducible).
Remove the properties for those parameters. The v3.0.0 release is a good time to do this.
> First of all we need to identify candidates for removal.
> This is the list of parameters/properties {{maven-war-plugin}} contains at the moment:
> {noformat}
> @Parameter( property = "archiveClasses", defaultValue = "false" )
>  @Parameter( property = "resourceEncoding", defaultValue = "${project.build.sourceEncoding}"
)
>  @Parameter( property = "maven.war.webxml" )
>  @Parameter( property = "maven.war.containerConfigXML" )
>  @Parameter( property = "useCache", defaultValue = "false" )
>  @Parameter( property = "maven.war.filteringDeploymentDescriptors", defaultValue = "false"
)
>  @Parameter( property = "maven.war.escapedBackslashesInFilePath", defaultValue = "false"
)
>  @Parameter( property = "maven.war.escapeString" )
>  @Parameter( property = "maven.war.supportMultiLineFiltering", defaultValue = "false"
)
>  @Parameter( property = "maven.war.useJvmChmod", defaultValue = "true" )
>  @Parameter( property = "primaryArtifact", defaultValue = "true" )
>  @Parameter( property = "failOnMissingWebXml", defaultValue = "true" )
>  @Parameter( property = "maven.war.skip", defaultValue = "false" )
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message