maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Patrick (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (MNG-5956) Invalid DuplicateProjectException if physically same pom.xml
Date Fri, 01 Jan 2016 01:51:39 GMT

    [ https://issues.apache.org/jira/browse/MNG-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15076214#comment-15076214
] 

John Patrick edited comment on MNG-5956 at 1/1/16 1:51 AM:
-----------------------------------------------------------

edit; wrong pull request source should be https://github.com/apache/maven/pull/75 for patch.

I think it matches the maven code standards. Not sure if anything else required before the
patch can be accepted.


was (Author: nhoj.patrick):
See pull request https://github.com/nhojpatrick/maven/pull/1 for patch.

I think it matches the maven code standards. Not sure if anything else required before the
patch can be accepted.

> Invalid DuplicateProjectException if physically same pom.xml
> ------------------------------------------------------------
>
>                 Key: MNG-5956
>                 URL: https://issues.apache.org/jira/browse/MNG-5956
>             Project: Maven
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 3.2.x
>         Environment: Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T16:41:47+00:00)
> Maven home: /opt/local/share/java/maven3
> Java version: 1.8.0_60, vendor: Oracle Corporation
> Java home: /Library/Java/JavaVirtualMachines/jdk1.8.0_60.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.11.2", arch: "x86_64", family: "mac"
>            Reporter: John Patrick
>              Labels: github-import, newbie, patch
>
> Several projects I've worked on have lots of modules, some to aid developers sub modules
have been hijacked to also build other projects. Take the following example.
> ./pom.xml
> ./common/pom.xml
> ./sub1/pom.xml
> ./sub2/pom.xml
> If sub1 and sub2 both include <module>../common</module> then DuplicateProjectException
is thrown. I've created a patch which before throwing the exception does one last check to
ignore instances where the clash is actually the same physical pom file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message