Return-Path: X-Original-To: apmail-maven-issues-archive@minotaur.apache.org Delivered-To: apmail-maven-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B05E218D63 for ; Tue, 1 Dec 2015 18:11:11 +0000 (UTC) Received: (qmail 26153 invoked by uid 500); 1 Dec 2015 18:11:11 -0000 Delivered-To: apmail-maven-issues-archive@maven.apache.org Received: (qmail 26095 invoked by uid 500); 1 Dec 2015 18:11:11 -0000 Mailing-List: contact issues-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list issues@maven.apache.org Received: (qmail 26049 invoked by uid 99); 1 Dec 2015 18:11:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Dec 2015 18:11:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 1F28C2C1F6F for ; Tue, 1 Dec 2015 18:11:11 +0000 (UTC) Date: Tue, 1 Dec 2015 18:11:11 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@maven.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MPMD-186) Class Name with slash is omitted from exclusions on pmd:check MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MPMD-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034233#comment-15034233 ] ASF GitHub Bot commented on MPMD-186: ------------------------------------- GitHub user gyrfalcon opened a pull request: https://github.com/apache/maven-plugins/pull/71 [MPMD-186] Fix Windows-Specific Constants Fixed a defect that caused certain PMD Violations to not be excluded correctly on non-Windows computers. See https://issues.apache.org/jira/browse/MPMD-186 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gyrfalcon/maven-plugins MPMD-186 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-plugins/pull/71.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #71 ---- commit 717219f228e76de2f101120e21868ce1809569bc Author: Justin Shepard Date: 2015-12-01T18:03:16Z [MPMD-186] Fix Windows-Specific Constants Fixed a defect that caused certain PMD Violations to not be excluded correctly on non-Windows computers. See https://issues.apache.org/jira/browse/MPMD-186 ---- > Class Name with slash is omitted from exclusions on pmd:check > ------------------------------------------------------------- > > Key: MPMD-186 > URL: https://issues.apache.org/jira/browse/MPMD-186 > Project: Maven PMD Plugin > Issue Type: Bug > Components: PMD > Affects Versions: 3.1 > Environment: Ubuntu 13.04 Jdk 1.7 Maven 3.1.1 > Reporter: Diego Almeida > Priority: Critical > Attachments: maven-pmd-plugin.patch > > > The method getFileName on class Violation returns the class name with slash or back slash. On the method extractClassName in the Class PmdViolationCheckMojo the backslashes are replaced with dots in order to compose the package name, but some > classes do not meet this condition and stay with the original class name and are not found on the map excludeFromFailureClasses that contains the classes and the rules with exceptions. > This generates an error even if the class and the rule are included on the exception file. -- This message was sent by Atlassian JIRA (v6.3.4#6332)