maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Osipov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MPMD-186) Class Name with slash is omitted from exclusions on pmd:check
Date Tue, 01 Dec 2015 18:33:12 GMT

    [ https://issues.apache.org/jira/browse/MPMD-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034303#comment-15034303
] 

Michael Osipov commented on MPMD-186:
-------------------------------------

[~justin.shepard], just checked your PR and I am willing to merge. I'd like to clarify something
in advance. The issue is simply that the the code is not OS-agnostic but blindly assumes that
Windows is used? Because when can a class name contain a slash?

> Class Name with slash is omitted from exclusions on pmd:check
> -------------------------------------------------------------
>
>                 Key: MPMD-186
>                 URL: https://issues.apache.org/jira/browse/MPMD-186
>             Project: Maven PMD Plugin
>          Issue Type: Bug
>          Components: PMD
>    Affects Versions: 3.1
>         Environment: Ubuntu 13.04  Jdk 1.7  Maven 3.1.1
>            Reporter: Diego Almeida
>            Priority: Critical
>         Attachments: maven-pmd-plugin.patch
>
>
> The method getFileName on class Violation returns the class name with slash or back slash.
On the method extractClassName in the Class PmdViolationCheckMojo the backslashes are replaced
with dots in order to compose the package name, but some
>  classes do not meet this condition and stay with the original class name and are not
found on the map excludeFromFailureClasses that contains the classes and the rules with exceptions.
> This generates an error even if the class and the rule are included on the exception
file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message