maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MSHARED-466) Filtering dependencies does not retain the order of the unfiltered list
Date Sat, 28 Nov 2015 11:42:10 GMT

    [ https://issues.apache.org/jira/browse/MSHARED-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15030473#comment-15030473
] 

Hudson commented on MSHARED-466:
--------------------------------

SUCCESS: Integrated in maven-shared #812 (See [https://builds.apache.org/job/maven-shared/812/])
[MSHARED-466] Filtering dependencies does not retain the order of the unfiltered list (khmarbaise:
[http://svn.apache.org/viewvc/?view=rev&rev=1716944])
* maven-common-artifact-filters/src/main/java/org/apache/maven/shared/artifact/filter/collection/AbstractArtifactFeatureFilter.java
* maven-common-artifact-filters/src/main/java/org/apache/maven/shared/artifact/filter/collection/AbstractArtifactsFilter.java


> Filtering dependencies does not retain the order of the unfiltered list
> -----------------------------------------------------------------------
>
>                 Key: MSHARED-466
>                 URL: https://issues.apache.org/jira/browse/MSHARED-466
>             Project: Maven Shared Components
>          Issue Type: Bug
>    Affects Versions: maven-common-artifact-filters-1.4
>            Reporter: Beirtí Ó'Nunáin
>            Assignee: Karl Heinz Marbaise
>             Fix For: maven-common-artifact-filters-3.0.0
>
>
> If you use the dependency:build-classpath mojo, you get the dependency list as specified
in the pom. However, if you introduce filtering, you end up losing the dependency order. It
seems that the org.apache.maven.shared.artifact.filter.collection.ArtifactsFilter declares
'Set' instead of 'SortedSet' and that the org.apache.maven.shared.artifact.filter.collection.AbstractArtifactFeatureFilter
returns a HashSet instead of a LinkedHashSet, even though a LinkedHashSet is being passed
in.
> The impact of this is that you cannot generate a correctly-ordered classpath when using
filters. The fix is very straightforward, simply change the filterIncludes and filterExcludes
methods of AbstractArtifactFeatureFilter to use a LinkedHashSet.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message