maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hervé Boutemy (JIRA) <j...@apache.org>
Subject [jira] [Commented] (MSHARED-442) Remove shading of artifact instead of using simple jar
Date Sat, 10 Oct 2015 09:41:05 GMT

    [ https://issues.apache.org/jira/browse/MSHARED-442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14951749#comment-14951749
] 

Hervé Boutemy commented on MSHARED-442:
---------------------------------------

sorry, I did not hav time to look at this before
I don't think this is a good idea either: commons-io as optional just will make the util blow
up if someone uses the class(es) that was(were) previously shaded

What is the problem you're trying to solve by removing shade?
rat failure?

> Remove shading of artifact instead of using simple jar
> ------------------------------------------------------
>
>                 Key: MSHARED-442
>                 URL: https://issues.apache.org/jira/browse/MSHARED-442
>             Project: Maven Shared Components
>          Issue Type: Improvement
>          Components: maven-shared-utils
>    Affects Versions: maven-shared-utils-0.9
>            Reporter: Karl Heinz Marbaise
>            Assignee: Karl Heinz Marbaise
>            Priority: Minor
>             Fix For: maven-shared-utils-3.0.0
>
>
> Currently the maven-shared-utils are being shaded during the build but why do we need
that? It would be simpler to use create a simple jar file instead. The old build included
commons-io into the shaded jar. commons-io dependency is defined optional.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message