maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MNG-5871) make url inheritance algorithm more visible
Date Sat, 31 Oct 2015 13:14:27 GMT

    [ https://issues.apache.org/jira/browse/MNG-5871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983990#comment-14983990
] 

Hudson commented on MNG-5871:
-----------------------------

SUCCESS: Integrated in maven-3.x #1149 (See [https://builds.apache.org/job/maven-3.x/1149/])
[MNG-5871] refactoring: improved empty urls handling (hboutemy: rev 2f7daeff5802174c7b4ff8a4d2ac019b6406d03b)
* maven-model-builder/src/main/java/org/apache/maven/model/inheritance/DefaultInheritanceAssembler.java
* maven-model-builder/src/test/resources/poms/inheritance/empty-urls-child.xml
* maven-model-builder/src/test/resources/poms/inheritance/empty-urls-expected.xml
* maven-model-builder/src/test/resources/poms/inheritance/empty-urls-parent.xml
* maven-model-builder/src/test/resources/poms/inheritance/empty-child.xml
* maven-model-builder/src/test/resources/poms/inheritance/empty-parent.xml
* maven-model-builder/src/test/java/org/apache/maven/model/inheritance/DefaultInheritanceAssemblerTest.java
* maven-model-builder/src/test/resources/poms/inheritance/empty-expected.xml


> make url inheritance algorithm more visible
> -------------------------------------------
>
>                 Key: MNG-5871
>                 URL: https://issues.apache.org/jira/browse/MNG-5871
>             Project: Maven
>          Issue Type: Improvement
>          Components: Inheritance and Interpolation
>    Affects Versions: 3.3.3
>            Reporter: Hervé Boutemy
>            Assignee: Hervé Boutemy
>             Fix For: 3.3.8
>
>
> currently, default urls calculated for child from parent values are often discussed
> but their implementation is no easy to find: it's a mix between
> - DefaultInheritanceAssembler.getChildPathAdjustment(, which calculates path adjustment
> - MavenModelBuilder.appendPath, that calculates the child url: in general, parent url
is used, but if childpathadjustment is set, this is the algorithm to extrapolate child from
parent
> IMHO, the test on childpathadjustement is a hack; in fact, we should use method overriding:
default method just returns arent, but DefaultInheritanceAssembler.InheritanceModelMerger
should override it with the extrapolation algorithm
> this would make the code a lot more clear and help for future enhancements



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message