Return-Path: 
 <issues-return-104108-apmail-maven-issues-archive=maven.apache.org@maven.apache.org>
X-Original-To: apmail-maven-issues-archive@minotaur.apache.org
Delivered-To: apmail-maven-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 7A3F9107D7
	for <apmail-maven-issues-archive@minotaur.apache.org>;
 Thu,  3 Sep 2015 07:51:46 +0000 (UTC)
Received: (qmail 61245 invoked by uid 500); 3 Sep 2015 07:51:46 -0000
Delivered-To: apmail-maven-issues-archive@maven.apache.org
Received: (qmail 61191 invoked by uid 500); 3 Sep 2015 07:51:46 -0000
Mailing-List: contact issues-help@maven.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@maven.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@maven.apache.org>
List-Post: <mailto:issues@maven.apache.org>
List-Id: <issues.maven.apache.org>
Reply-To: dev@maven.apache.org
Delivered-To: mailing list issues@maven.apache.org
Received: (qmail 61179 invoked by uid 99); 3 Sep 2015 07:51:46 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Sep 2015 07:51:46 +0000
Date: Thu, 3 Sep 2015 07:51:46 +0000 (UTC)
From: =?utf-8?Q?Micha=C5=82_=28JIRA=29?= <jira@apache.org>
To: issues@maven.apache.org
Message-ID: <JIRA.12860974.1441106656000.244211.1441266706250@Atlassian.JIRA>
In-Reply-To: <JIRA.12860974.1441106656000@Atlassian.JIRA>
References: <JIRA.12860974.1441106656000@Atlassian.JIRA>
 <JIRA.12860974.1441106656556@arcas>
Subject: [jira] [Comment Edited] (MCLEAN-64) Multiple filesets for removing
 directories
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/MCLEAN-64?page=3Dcom.atlassian.=
jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D14728=
634#comment-14728634 ]=20

Micha=C5=82 edited comment on MCLEAN-64 at 9/3/15 7:51 AM:
------------------------------------------------------

OK I have found the issue!

Situation
You have a parent project and a child project, both have to use the plugin.

Now;=20
- in parent project you specify some filesets.
- in child project you specify some filesets.

---
What I think is expected:
Plugin read both parent's and child's filesets and cleans them all.

What happens:
Plugin OVERRIDES the parent's filesets with child's filesets. Filesets are =
overriden in order. HOWEVER the parents configuration for the fileset is no=
t cleared!

---
My situation:
Parent .pom:
{code:xml}
<filesets>
<fileset>
    <directory>test-output</directory>
</fileset>
<fileset>
<directory>${basedir}/</directory>
<includes>
    <include>.bindings</include>
</includes>
</fileset>
</filesets>
{code}

Childs pom:
{code:xml}
<filesets>
    <fileset>
        <directory>node</directory>
    </fileset>
    <fileset>
        <directory>node_modules</directory>
    </fileset>
    <fileset>
        <directory>src/main/webapp/bower_components</directory>
    </fileset>
</filesets>
{code}

And with the above information; the filesets read by plugin is:
{code:xml}
<filesets>
    <fileset>
        <directory>node</directory>
    </fileset>
    <fileset>
        <directory>node_modules</directory>
        <includes>
            <include>.bindings</include>
        </includes>
    </fileset>
    <fileset>
        <directory>src/main/webapp/bower_components</directory>
    </fileset>
</filesets>
{code}

instead of a config with 5 filesets.




was (Author: atais):
OK I have found the issue!

Situation
You have a parent project and a child project, both have to use the plugin.

Now;=20
- in parent project you specify some filesets.
- in child project you specify some filesets.

---
What I think is expected:
Plugin read both parent's and child's filesets and cleans them all.

What happens:
Plugin OVERRIDES the parent's filesets with child's filesets. Filesets are =
overriden in order. HOWEVER the parents configuration for the fileset is no=
t cleared!

---
My situation:
Parent .pom:
{code:xml}
<fileset>
                            <directory>test-output</directory>
                        </fileset>
                        <fileset>
                            <directory>${basedir}/</directory>
                            <includes>
                                <include>.bindings</include>
                            </includes>
                        </fileset>
{code}

Childs pom:
{code:xml}
<filesets>
                        <fileset>
                            <directory>node</directory>
                        </fileset>
                        <fileset>
                            <directory>node_modules</directory>
                        </fileset>
                        <fileset>
                            <directory>src/main/webapp/bower_components</di=
rectory>
                        </fileset>
                    </filesets>
{code}

And with the above information; the filesets read by plugin is:
{code:xml}
<filesets>
                        <fileset>
                            <directory>node</directory>
                        </fileset>
                        <fileset>
                            <directory>node_modules</directory>
<includes>
                                <include>.bindings</include>
                            </includes>
                        </fileset>
                        <fileset>
                            <directory>src/main/webapp/bower_components</di=
rectory>
                        </fileset>
                    </filesets>
{code}

instead of a config with 5 filesets.



> Multiple filesets for removing directories=20
> -------------------------------------------
>
>                 Key: MCLEAN-64
>                 URL: https://issues.apache.org/jira/browse/MCLEAN-64
>             Project: Maven Clean Plugin
>          Issue Type: Bug
>    Affects Versions: 2.6.1
>         Environment: Apache Maven 3.3.3 (7994120775791599e205a5524ec3e0df=
e41d4a06; 2015-04-22T13:57:37+02:00)
> Maven home: /home/msiatkowski/.linuxbrew/Cellar/maven/3.3.3/libexec
> Java version: 1.8.0_51, vendor: Oracle Corporation
> Java home: /usr/lib/jvm/java-8-oracle/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "3.13.0-61-generic", arch: "amd64", family: "u=
nix"
>            Reporter: Micha=C5=82
>
> If you configure the plugin in the way shown below:
> {code:xml}
> <configuration>
>     <filesets>
>         <fileset>
>             <directory>node</directory>
>         </fileset>
>         <fileset>
>             <directory>node_modules</directory>
>         </fileset>
>         <fileset>
>             <directory>src/main/webapp/bower_components</directory>
>         </fileset>
>     </filesets>
> </configuration>
> {code}
> The 2nd fileset always contains
> {code:xml}
> <includes>
>     <include>.bindings</include>
> </includes>
> {code}
> even when not specified.
> The issue is described here:
> http://stackoverflow.com/questions/32329141/maven-clean-plugin-is-not-rem=
oving-all-given-directories/32330215#32330215



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)