maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hervé Boutemy (JIRA) <j...@apache.org>
Subject [jira] [Commented] (MRELEASE-899) release:prepare should not change the line separator
Date Sat, 29 Aug 2015 07:09:46 GMT

    [ https://issues.apache.org/jira/browse/MRELEASE-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14720998#comment-14720998
] 

Hervé Boutemy commented on MRELEASE-899:
----------------------------------------

you "prefer to configure (your) Git with option "check out as-is, commit UNIX"", ie not like
thousands of developpers who work on multi-OS configuration (then choose autocrlf=true): that's
your choice
I just tell you that:
1. you chose the hard way, for an unknown reason (perhaps the message in the git client you're
using makes you think that changing line ending is bad, but it is good. You can have a look
at git official documentation on this: https://git-scm.com/book/tr/v2/Customizing-Git-Git-Configuration#Formatting-and-Whitespace
)
2. I'm working on Maven on my free time and I have a lot to do: one way to not add more work
is to avoid the hard way

Then, to limit friutration waiting for something that won't happen, I'm clear with you:
1. I won't take time on coding this feature myself
2. but if somebody works on it, I'm ready to take time to integrate. How can you convince
someone to write code for the feature? I don't know: pay someone? Or perhaps someone reads
this Jira issue and is interested in coding the feature.

And to help you, I tell you the feature everybody I know uses: source control management line
ending management, ie autocrlf=true on git

> release:prepare should not change the line separator
> ----------------------------------------------------
>
>                 Key: MRELEASE-899
>                 URL: https://issues.apache.org/jira/browse/MRELEASE-899
>             Project: Maven Release Plugin
>          Issue Type: Improvement
>            Reporter: Ralph van Etten
>
> Currently the plugin use the system property {{line.separator}} when it rewrites the
pom.xml.
> This causes trouble, because every line in changed, when a project is released sometimes
under Windows and sometimes under Linux (because of its different line separators). (http://stackoverflow.com/questions/11868590/maven-release-plugin-and-windows-line-breaks)
> Therefore it would be a nice feature when the plugin would not use the systems line separator
but the line separator that is already used in the pom.xml.
> On the other hand, changing the existing behaviour would maybe, also harm someone else.
> Therefore it would be an great feature when there would be an property that define the
expected behaviour, maybe in the same way it is done by the maven-assembly-plugin's property
fileSet.lineEnding (http://maven.apache.org/plugins/maven-assembly-plugin/component.html#class_fileSet)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message