Return-Path: 
 <issues-return-103048-apmail-maven-issues-archive=maven.apache.org@maven.apache.org>
X-Original-To: apmail-maven-issues-archive@minotaur.apache.org
Delivered-To: apmail-maven-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id CDC7718079
	for <apmail-maven-issues-archive@minotaur.apache.org>;
 Thu,  2 Jul 2015 13:54:04 +0000 (UTC)
Received: (qmail 75682 invoked by uid 500); 2 Jul 2015 13:54:04 -0000
Delivered-To: apmail-maven-issues-archive@maven.apache.org
Received: (qmail 75628 invoked by uid 500); 2 Jul 2015 13:54:04 -0000
Mailing-List: contact issues-help@maven.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@maven.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@maven.apache.org>
List-Post: <mailto:issues@maven.apache.org>
List-Id: <issues.maven.apache.org>
Reply-To: dev@maven.apache.org
Delivered-To: mailing list issues@maven.apache.org
Received: (qmail 75615 invoked by uid 99); 2 Jul 2015 13:54:04 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Jul 2015 13:54:04 +0000
Date: Thu, 2 Jul 2015 13:54:04 +0000 (UTC)
From: "Michael McCarthy (JIRA)" <jira@apache.org>
To: issues@maven.apache.org
Message-ID: <JIRA.12842327.1435845190000.84969.1435845244548@Atlassian.JIRA>
In-Reply-To: <JIRA.12842327.1435845190000@Atlassian.JIRA>
References: <JIRA.12842327.1435845190000@Atlassian.JIRA>
 <JIRA.12842327.1435845190927@arcas>
Subject: [jira] [Created] (MSHADE-197) Shade fails to relocate packages for
 all classes
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394

Michael McCarthy created MSHADE-197:
---------------------------------------

             Summary: Shade fails to relocate packages for all classes
                 Key: MSHADE-197
                 URL: https://issues.apache.org/jira/browse/MSHADE-197
             Project: Maven Shade Plugin
          Issue Type: Bug
    Affects Versions: 2.4
         Environment: Windows 7, Maven 3.0.5
            Reporter: Michael McCarthy


I attempted to relocate the org.apache.http.* packages using the shade plugin on the AWS Java SDK. This fails to update the location for at least one class, com.amazonaws.services.s3.model.S3ObjectInputStream. I manually updated the source code to use the shaded location and it compiled without issue:

import org.shaded.http.client.HttpClient;
import org.shaded.http.client.methods.HttpRequestBase;
import org.shaded.http.conn.EofSensorInputStream;

Before making the above change, the error I get is:
[ERROR] 
\dev\CSJ\aws\temp\aws-sdk-java\aws-java-sdk-s3\src\main\java\com\amazonaws\services\s3\internal\S3ObjectResponseHandler.java:[54,26]

error: no suitable constructor found for S3ObjectInputStream(InputStream,org.shaded.http.client.methods.HttpRequestBase)

The configuration I used in pom.xml was:
<plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-shade-plugin</artifactId>
    <version>2.4</version>
    <configuration>
       <artifactSet>
          <includes>
             <include>com.amazonaws:*</include>
<include>org.apache.httpcomponents:*</include>
          </includes>
       </artifactSet>
       <relocations>
          <relocation>
             <pattern>org.apache.http</pattern>
<shadedPattern>org.shaded.http</shadedPattern>
          </relocation>
       </relocations>
    </configuration>
    <executions>
       <execution>
          <phase>package</phase>
          <goals>
             <goal>shade</goal>
          </goals>
       </execution>
    </executions>
</plugin>

See http://mail-archives.apache.org/mod_mbox/maven-users/201506.mbox/%3C558BE1C5.2020400%40tribloom.com%3E for more details. This thread has instructions on how to reproduce as well as links to a Github project with the changes already made and the error easy to reproduce.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)