maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tibor Digana (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SUREFIRE-1166) Include/Exclude regex pattern for a path is incorrectly replaced on Windows
Date Tue, 07 Jul 2015 09:23:04 GMT

    [ https://issues.apache.org/jira/browse/SUREFIRE-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616412#comment-14616412
] 

Tibor Digana commented on SUREFIRE-1166:
----------------------------------------

This part was changed completely. There is TestListResolver and TestResult.
You should start with DependencyScanner and then the Filter.
The thing is that ZIP archive uses normal slash '/' and the directory uses the system slash.
We use MatchPatterns in external library which performs regex match in ResolvedTest. Probably
this library needs bug fix due to slash should be replaced with system path.

I think there is some investigation you need to do first.

Unfortunately I do not have time for this because I am resolving last planned issues for the
release 2.19.
I want to cut the release in two weeks so this fix is on your side.

> Include/Exclude regex pattern for a path is incorrectly replaced on Windows
> ---------------------------------------------------------------------------
>
>                 Key: SUREFIRE-1166
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1166
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: Maven Failsafe Plugin
>    Affects Versions: 2.18.1
>         Environment: Windows
>            Reporter: Matthias Gradl
>
> On non-unix systems, the file scanner converts slashes ("/") into the file-system appropriate
separator (eg. "\" on Windows) thus colliding with the standard escape character in regex
Strings.
> For regex pattern matching a path (segment) to a test package (like: "%regex[.*/smoketest/.*Test\.java]"
this leads to unusable patterns: "%regex[.*\smoketest\.*Test\.java]"
> There needs to be a more sophisticated replacement happening when the include string
is actually a regex pattern.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message