maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthias Gradl (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SUREFIRE-1166) Include/Exclude regex pattern for a path is incorrectly replaced on Windows
Date Tue, 07 Jul 2015 08:27:04 GMT

    [ https://issues.apache.org/jira/browse/SUREFIRE-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616366#comment-14616366
] 

Matthias Gradl commented on SUREFIRE-1166:
------------------------------------------

Yup, the patch was based on 2.18.1, but I rebased it to master before posting it here. Figured
you would probably not do a fixed 2.18.2 anyway.

I underestimated the conflict that showed during the rebase of the patch commit. Just looked
into the improved filters code and can't tell yet if it fixes the issue, but I'm just running
the IT again.

> Include/Exclude regex pattern for a path is incorrectly replaced on Windows
> ---------------------------------------------------------------------------
>
>                 Key: SUREFIRE-1166
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1166
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: Maven Failsafe Plugin
>    Affects Versions: 2.18.1
>         Environment: Windows
>            Reporter: Matthias Gradl
>
> On non-unix systems, the file scanner converts slashes ("/") into the file-system appropriate
separator (eg. "\" on Windows) thus colliding with the standard escape character in regex
Strings.
> For regex pattern matching a path (segment) to a test package (like: "%regex[.*/smoketest/.*Test\.java]"
this leads to unusable patterns: "%regex[.*\smoketest\.*Test\.java]"
> There needs to be a more sophisticated replacement happening when the include string
is actually a regex pattern.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message