maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dennis Lundberg (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (MPMD-206) Make the sourceDirectories configurable
Date Mon, 01 Jun 2015 08:58:18 GMT

    [ https://issues.apache.org/jira/browse/MPMD-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14567045#comment-14567045
] 

Dennis Lundberg edited comment on MPMD-206 at 6/1/15 8:58 AM:
--------------------------------------------------------------

Hi [~adangel],

I've had a look at your pull request, and I feel that it makes some unnecessary changes to
achieve what I think that you want to. If understand this issue correctly, you want to be
able to configure which source directories should be analyzed by PMD without using {{build-helper-maven-plugin}}.

We do not need new parameters for this. I think it can be accomplished by simply removing
the {{readonly = true}} attribute of the {{compileSourceRoots}} and {{testSourceRoots}} parameters.
I will do some testing and see how it goes.


was (Author: dennisl@apache.org):
Hi [~adangel],

I've had a look at your pull request, and I feel that it makes some unnecessary changes to
achieve what I think that you want to. If understand this issue correctly, you want to be
able to configure which source directories should be analyzed by PMD without using {{build-helper-maven-plugin}}.

We do not need new parameters for this. I think it can be accomplished by simply removing
the {{readonly = true }} attribute of the {{compileSourceRoots}} and {{testSourceRoots}} parameters.
I will do some testing and see how it goes.

> Make the sourceDirectories configurable
> ---------------------------------------
>
>                 Key: MPMD-206
>                 URL: https://issues.apache.org/jira/browse/MPMD-206
>             Project: Maven PMD Plugin
>          Issue Type: Improvement
>          Components: CPD, PMD
>    Affects Versions: 3.4
>            Reporter: Andreas Dangel
>
> When analyzing a language other than Java, the sources currently have to be added by
using the build-helper-maven-plugin to add additional source folders.
> This change adds the parameters {{sourceDirectories}} and {{testSourceDirectories}},
similarly as it is done in the checkstyle plugin.
> I'll provide a pull request for this: https://github.com/apache/maven-plugins/pull/47



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message