Return-Path: X-Original-To: apmail-maven-issues-archive@minotaur.apache.org Delivered-To: apmail-maven-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 986AF17D42 for ; Tue, 20 Jan 2015 21:10:13 +0000 (UTC) Received: (qmail 10419 invoked by uid 500); 20 Jan 2015 21:10:13 -0000 Delivered-To: apmail-maven-issues-archive@maven.apache.org Received: (qmail 10369 invoked by uid 500); 20 Jan 2015 21:10:13 -0000 Mailing-List: contact issues-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list issues@maven.apache.org Received: (qmail 10358 invoked by uid 99); 20 Jan 2015 21:10:12 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Jan 2015 21:10:12 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [199.193.192.100] (HELO codehaus01.managed.contegix.com) (199.193.192.100) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Jan 2015 21:10:08 +0000 Received: from codehaus01 (localhost.localdomain [127.0.0.1]) by codehaus01.managed.contegix.com (Postfix) with ESMTP id 29B92B1161 for ; Tue, 20 Jan 2015 15:08:18 -0600 (CST) Date: Tue, 20 Jan 2015 15:08:18 -0600 (CST) From: "Michael Osipov (JIRA)" To: issues@maven.apache.org Message-ID: In-Reply-To: References: Subject: [jira] (MPMD-199) Support PMD functionality on JSP files MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 22cf62d5d84cf5bea94eb3b65e0ebd09 X-Virus-Checked: Checked by ClamAV on apache.org [ https://jira.codehaus.org/browse/MPMD-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=361482#comment-361482 ] Michael Osipov commented on MPMD-199: ------------------------------------- Tom, way better now. A few issues though: 1. {{sample.jsp}} is added twice, ins't it? 2. You copied the javascript apt file to {{jspReport.apt.vm}} but did not alter its content. 3. You either need to add the JSP module to the plugins dependencies and/or make it optional and tell that actually in the docs. > Support PMD functionality on JSP files > -------------------------------------- > > Key: MPMD-199 > URL: https://jira.codehaus.org/browse/MPMD-199 > Project: Maven PMD Plugin > Issue Type: Improvement > Components: PMD > Affects Versions: 3.3 > Reporter: Tom Williamson > Priority: Minor > Attachments: Jsp_support_201501201341.patch, Patch_for_JSP_support.patch > > > It would be great if this plugin would either support PMD functionality for JSP files, or simply enable them as part of the Java support. -- This message was sent by Atlassian JIRA (v6.1.6#6162)