maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Herve Boutemy (JIRA)" <j...@codehaus.org>
Subject [jira] (MPLUGIN-279) improve jdk requirement when m-compiler-p not explicitely configured: use default properties
Date Sun, 14 Dec 2014 19:42:10 GMT

    [ https://jira.codehaus.org/browse/MPLUGIN-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=359068#comment-359068
] 

Herve Boutemy edited comment on MPLUGIN-279 at 12/14/14 1:40 PM:
-----------------------------------------------------------------

bq. If I understood you correctly, this would solve exactly the corner case I have described
in the ticket: runtme evaluation?
yes, even if I wouldn't say it like this: this is default parameter value evaluation (which
is effectively not in plugin configuration)

bq. Unfortunately, this only works for target what about source
this does not only *work* for target, this *is coded* only for {{target}}: if coding something
for {{source}} is useful, just do it, the algorithm is clear in the latest implementation

bq. The proposed fix actually violates that statement. Since plugins run in isolated classloaders,
shouldn't the config be isolated too?
There is absolutely no shared object between the plugins: the plugin-plugin just reads the
project config and get Strings from a configuration (like it does for many years)
So I don't expect any problem: I suppose there was some misunderstanding during the hangout


Copy/pasting is the simplest solution: the most important thing is to write it and continue
to work together until we tested it well and do a component.
I don't like copy/pasting either, but experience with doing a shared component like this proves
it adds release and test complexity: once the code is well tested, putting it in a component
is the best, but trying to put it in a compoentn before it is well tested give more headaches

Notice that another virtue is to keep algorithms simple and easy to understand: I'm quite
satisfied with the latest.
Copy/pasting such limited algorithms is then a more acceptable compromise


was (Author: hboutemy):
bq. If I understood you correctly, this would solve exactly the corner case I have described
in the ticket: runtme evaluation?
yes

bq. Unfortunately, this only works for target what about source
this does not only *work* for target, this *is coded* only for {{target}}: if coding something
for {{source}} is useful, just do it, the algorithm is clear in the latest implementation

bq. The proposed fix actually violates that statement. Since plugins run in isolated classloaders,
shouldn't the config be isolated too?
There is absolutely no shared object between the plugins: the plugin-plugin just reads the
project config and get Strings from a configuration (like it does for many years)
So I don't expect any problem: I suppose there was some misunderstanding during the hangout


Copy/pasting is the simplest solution: the most important thing is to write it and continue
to work together until we tested it well and do a component.
I don't like copy/pasting either, but experience with doing a shared component like this proves
it adds release and test complexity: once the code is well tested, putting it in a component
is the best, but trying to put it in a compoentn before it is well tested give more headaches

Notice that another virtue is to keep algorithms simple and easy to understand: I'm quite
satisfied with the latest.
Copy/pasting such limited algorithms is then a more acceptable compromise

> improve jdk requirement when m-compiler-p not explicitely configured: use default properties
> --------------------------------------------------------------------------------------------
>
>                 Key: MPLUGIN-279
>                 URL: https://jira.codehaus.org/browse/MPLUGIN-279
>             Project: Maven Plugin Tools
>          Issue Type: Improvement
>          Components: Plugin Plugin
>    Affects Versions: 3.3
>            Reporter: Herve Boutemy
>            Assignee: Herve Boutemy
>             Fix For: 3.4
>
>
> When m-compiler-p has no explicit configuration, plugin-info report displays "Default
target for maven-compiler-plugin version xxx"
> This message is misleading, since default target can be set with {{$\{maven.compiler.target}}}
property
> The detection algorithm should look for this property



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)

Mime
View raw message