maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Osipov (JIRA)" <j...@codehaus.org>
Subject [jira] (SCM-504) CVS Tag Command Not Respecting Single File in ScmFileSet
Date Tue, 25 Nov 2014 20:32:13 GMT

     [ https://jira.codehaus.org/browse/SCM-504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael Osipov closed SCM-504.
------------------------------

    Resolution: Won't Fix

Please refer to https://cwiki.apache.org/confluence/display/MAVEN/The+Great+JIRA+Cleanup+of+2014
if you're wondering why this issue was closed out.

> CVS Tag Command Not Respecting Single File in ScmFileSet
> --------------------------------------------------------
>
>                 Key: SCM-504
>                 URL: https://jira.codehaus.org/browse/SCM-504
>             Project: Maven SCM
>          Issue Type: Bug
>          Components: maven-scm-provider-cvs
>    Affects Versions: 1.1
>            Reporter: Paul Lissak
>
> The CVS tag command is not checking the given ScmFileSet for individual files.  This
code snippet attempts to apply a tag to just one file:
>     public void applyTag(String tag, File projectFolder, String filename, ScmRepository
scmRepository, ScmProvider scmProvider) {
>         ScmFileSet fileSet = new ScmFileSet(projectFolder, new File(filename));
>         scmProvider.tag(scmRepository, fileSet, tag);
>     }
> Lets say the given tag is "TAG_NAME" and the filename is "Example.java", then this is
what CVS command is generated:
>     cvs -z3 -f -q tag -F -c TAG_NAME
> The correct CVS command should be:
>     cvs -z3 -f -q tag -F -c TAG_NAME Example.java
> The problem appears to be in the following method:
>     org.apache.maven.scm.provider.cvslib.command.tag.AbstractCvsTagCommand.executeTagCommand(ScmProviderRepository,ScmFileSet,String,String)
> The method needs to call getFileList() on the ScmFileSet to see if any individual files
are present and then add them to the generated CVS tag command.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)

Mime
View raw message