maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Osipov (JIRA)" <j...@codehaus.org>
Subject [jira] (MECLIPSE-454) WTP default server configuration only used for Websphere (and not for JBoss and others)
Date Tue, 25 Nov 2014 20:32:21 GMT

     [ https://jira.codehaus.org/browse/MECLIPSE-454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michael Osipov closed MECLIPSE-454.
-----------------------------------

    Resolution: Won't Fix

Please refer to https://cwiki.apache.org/confluence/display/MAVEN/The+Great+JIRA+Cleanup+of+2014
if you're wondering why this issue was closed out.

> WTP default server configuration only used for Websphere (and not for JBoss and others)
> ---------------------------------------------------------------------------------------
>
>                 Key: MECLIPSE-454
>                 URL: https://jira.codehaus.org/browse/MECLIPSE-454
>             Project: Maven Eclipse Plugin
>          Issue Type: Bug
>          Components: WTP support
>    Affects Versions: 2.5.1
>         Environment: Windows XP SP3, JDK 1.5.0_14, Eclipse 3.3.2, Maven 2.0.8
>            Reporter: M.-Leander Reimer
>            Priority: Minor
>         Attachments: EclipseWtpFacetsWriter.java
>
>
> The <wtpdefaultserver> configuration setting is currently only used for Websphere
servers. But shouldn't setting this to some other server also lead to a <runtime> definition
in the Eclipse facets XML file (org.eclipse.wst.common.project.facet.core.xml)?
> For example:
> <wtpdefaultserver>JBoss v4.2</wtpdefaultserver> 
> should produce
> <runtime name="JBoss v4.2"/>
> The minimal changes I made to correct this are in EclipseWtpFacetsWriter.writeModuleTypeFacetCore(
XMLWriter writer, String packaging ) line 136 ...
> I have simply put the relevant 3 lines out of the Websphere specific if statement.
>             if (config.getWorkspaceConfiguration().getDefaultDeployServerName() != null)
{
>                 writer.startElement( "runtime" );
>                 writer.addAttribute( "name", config.getWorkspaceConfiguration().getDefaultDeployServerName()
);
>                 writer.endElement(); // runtime
>             }
>             
>             if ( this.config.getWorkspaceConfiguration().getWebsphereVersion() != null
)
>             {
>                 writeFacetInstalledElement( writer, FACET_COM_IBM_WEBSPHERE_EXTENDED_EAR,
>                                             this.config.getWorkspaceConfiguration().getWebsphereVersion()
); // installed
>                 writeFacetInstalledElement( writer, FACET_COM_IBM_WEBSPHERE_COEXISTENCE_EAR,
>                                             this.config.getWorkspaceConfiguration().getWebsphereVersion()
); // installed
>             }
> Best regards,
> Leander



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)

Mime
View raw message