maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Pokrovsky (JIRA)" <j...@codehaus.org>
Subject [jira] (MCHECKSTYLE-244) LicenseResourceManager component is not thread safe and causes parallel build failures
Date Mon, 18 Aug 2014 12:37:10 GMT

    [ https://jira.codehaus.org/browse/MCHECKSTYLE-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=351575#comment-351575
] 

Konstantin Pokrovsky commented on MCHECKSTYLE-244:
--------------------------------------------------

I've reproduced the issue on internal maven project with 20-30 modules: ~1-2 failures per
10-20 checkstyle-only builds before the fix. After the fix I've stopped testing on 100 consecutive
successful builds.

> LicenseResourceManager component is not thread safe and causes parallel build failures
> --------------------------------------------------------------------------------------
>
>                 Key: MCHECKSTYLE-244
>                 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-244
>             Project: Maven Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.12, 2.12.1
>            Reporter: Konstantin Pokrovsky
>         Attachments: MCHECKSTYLE-244.patch
>
>
> {{LicenseResouceManager}} component does not specify instantiation strategy. By default
plexus uses singleton strategey which leads to {{ConcurrentModificationException}} in parallel
maven builds.
> Example: when two {{DefaultCheckstyleExecutors}} try to use one licence manager: one
calls {{addSearchPath}} on {{FileResourceLoader}} while the other one iterating over paths
in {{getResource}} on the same {{FileResourceLoader}} .
> MCHECKSTYLE-238 and MCHECKSTYLE-230 are exactly about this situation. Right now the plugin
for some reason is marked as thread safe although it definetly produces exceptions in parallel
multimodule builds.
> {{DefaultCheckstyleRssGenerator}} is a point of attention because it is also singleton
instantiated.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)

Mime
View raw message