maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "J Knurek (JIRA)" <j...@codehaus.org>
Subject [jira] (SUREFIRE-778) failIfNoTests=false should not be required when using -Dtest=MyTestClass in multi-module reactor builds
Date Sat, 26 Apr 2014 00:09:10 GMT

    [ https://jira.codehaus.org/browse/SUREFIRE-778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=345375#comment-345375
] 

J Knurek commented on SUREFIRE-778:
-----------------------------------

It looks like the simple solution is that the default of AbstractSurefireMojo.getEffectiveFailIfNoTests()
@line 1359
should be {{false}} instead of {{true}}

I'm hesitant to make the change cause this is the first moment of me looking through the codebase.


> failIfNoTests=false should not be required when using -Dtest=MyTestClass in multi-module
reactor builds
> -------------------------------------------------------------------------------------------------------
>
>                 Key: SUREFIRE-778
>                 URL: https://jira.codehaus.org/browse/SUREFIRE-778
>             Project: Maven Surefire
>          Issue Type: Improvement
>    Affects Versions: 2.10
>            Reporter: Scott Carey
>
> Configure a trivial multi-module build with two tests (TestA, TestB) and two modules,
one test in each module.
> a multi-module aggregate build will succeed with
> 'mvn test'
> but fail with 
> 'mvn test -Dtest=TestA'
> This happens with 2.10, but does not with 2.6 for http://avro.apache.org/ (https://issues.apache.org/jira/browse/AVRO-935)
> This is related to bug
> http://jira.codehaus.org/browse/SUREFIRE-464
> -Dtest=Foo should not require that every module have a matching Foo, only one needs match.
 Or to simplify things, don't automatically switch from failIfNoTests=false to failIfNoTests=true
when -Dtest= is set at all.  
> Users who are running one test by  hand don't need this behavior (they will notice if
the test they are trying to run doesn't run) and automated tools/scripts that use this parameter
that want it to fail should set -DfailIfNoTests=true.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)

Mime
View raw message