maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakub Srba (JIRA)" <j...@codehaus.org>
Subject [jira] (MWAR-225) Add support for customizing filtering delimiters like the resources plugin
Date Fri, 09 Aug 2013 09:43:52 GMT

    [ https://jira.codehaus.org/browse/MWAR-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=330363#comment-330363
] 

Jakub Srba edited comment on MWAR-225 at 8/9/13 4:43 AM:
---------------------------------------------------------

I also need this, for freemarker templates that use ${}, which I don't want to be accidentally
replaced by properties from maven.

Patch that solves this is included.

The usage is like this:
{code:xml}
<plugin>
	<artifactId>maven-war-plugin</artifactId>
	<version>2.5-SNAPSHOT</version>
	<configuration>
		<webResources>
			<webResource>
				<directory>src/main/webapp</directory>
				<filtering>true</filtering>
			</webResource>
		</webResources>
		<delimiters>
			<delimiter>@</delimiter>
		</delimiters>
		<useDefaultDelimiters>false</useDefaultDelimiters>
	</configuration>
</plugin>
{code}
                
      was (Author: jakub.srba):
    I also need this, for freemarker templates that use ${}, which I don't want to be accidentally
replaced by properties from maven.

Patch that solves this is included.
                  
> Add support for customizing filtering delimiters like the resources plugin
> --------------------------------------------------------------------------
>
>                 Key: MWAR-225
>                 URL: https://jira.codehaus.org/browse/MWAR-225
>             Project: Maven WAR Plugin
>          Issue Type: Improvement
>          Components: filtering
>    Affects Versions: 2.1-beta-1
>            Reporter: Peter Runge
>            Priority: Minor
>         Attachments: MWAR-255.patch
>
>
> After recently upgrading to Maven3 beta1 from alpha7 I noticed that our filters were
not taking effect any more.  We were using '@' for creating filer tokens, which used to work
alpha7 but no more with beta1.
> In any case, looking at the resources plugin, it has a delimiters property that can be
used to customize the delimiters when filtering.  As suggested by 
> http://stackoverflow.com/questions/2315009/override-mavens-default-resource-filter-replacement-pattern
> I set an appropriate property on the resources plugin, but no such property exists for
the WAR plugin at the moment which means I am stuck.  I need to keep the delimiter token as
'@' because we need to maintain Ant compatibility for the time being.
> It would be nice if this property also existed on the WAR plugin so that filtering delimiters
could be customized.
> The code in the resources plugin that does the job:
> http://maven.apache.org/plugins/maven-resources-plugin/xref/org/apache/maven/plugin/resources/ResourcesMojo.html#233

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message