Return-Path: X-Original-To: apmail-maven-issues-archive@minotaur.apache.org Delivered-To: apmail-maven-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 593A41068E for ; Thu, 25 Jul 2013 20:19:31 +0000 (UTC) Received: (qmail 27061 invoked by uid 500); 25 Jul 2013 20:19:31 -0000 Delivered-To: apmail-maven-issues-archive@maven.apache.org Received: (qmail 27005 invoked by uid 500); 25 Jul 2013 20:19:31 -0000 Mailing-List: contact issues-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list issues@maven.apache.org Received: (qmail 26997 invoked by uid 99); 25 Jul 2013 20:19:31 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Jul 2013 20:19:31 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [199.193.192.100] (HELO codehaus01.managed.contegix.com) (199.193.192.100) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Jul 2013 20:19:26 +0000 Received: from codehaus01 (localhost.localdomain [127.0.0.1]) by codehaus01.managed.contegix.com (Postfix) with ESMTP id 89372B105D for ; Thu, 25 Jul 2013 15:19:05 -0500 (CDT) Date: Thu, 25 Jul 2013 15:19:05 -0500 (CDT) From: "Mirko Friedenhagen (JIRA)" To: issues@maven.apache.org Message-ID: In-Reply-To: References: Subject: [jira] (MENFORCER-159) Add goal recommend which will only warn but never fail a build MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 22cf62d5d84cf5bea94eb3b65e0ebd09 X-Virus-Checked: Checked by ClamAV on apache.org [ https://jira.codehaus.org/browse/MENFORCER-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=329517#comment-329517 ] Mirko Friedenhagen commented on MENFORCER-159: ---------------------------------------------- [~rfscholte], [~olamy]: Now we have the situation, that both MENFORCER-159 and MENFORCER-160 are merged. I think we either should levels as outlined in MENFORCER-160 or the additional goal as contributed in MENFORCER-159. Having both seems to be confusing :-). What about discussing which approach to choose on the developer's list? > Add goal recommend which will only warn but never fail a build > -------------------------------------------------------------- > > Key: MENFORCER-159 > URL: https://jira.codehaus.org/browse/MENFORCER-159 > Project: Maven 2.x Enforcer Plugin > Issue Type: New Feature > Components: Plugin > Affects Versions: 1.3 > Reporter: Mirko Friedenhagen > Assignee: Olivier Lamy > Fix For: 2.0 > > Attachments: recommend-mojo.patch > > > In our company's parent POM we define a lot of rules, some of which are controversial or may not be easily fulfilled. The patch I attach defines a new goal "recommend" which will always warn but never fail. It's configuration is done by a new element {{recommendations}} which just holds a sequence of rules. > I extracted most of EnforceMojo to AbstractEnforceMojo to avoid code duplication. I added an invoker test and all tests ran successfully. > See https://github.com/apache/maven-enforcer/pull/4 as well for easier review. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira