maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mirko Friedenhagen (JIRA)" <j...@codehaus.org>
Subject [jira] (MENFORCER-159) Add goal recommend which will only warn but never fail a build
Date Wed, 10 Jul 2013 21:02:05 GMT

     [ https://jira.codehaus.org/browse/MENFORCER-159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Mirko Friedenhagen updated MENFORCER-159:
-----------------------------------------

    Description: 
In our company's parent POM we define a lot of rules, some of which are controversial or may
not be easily fulfilled. The patch I attach defines a new goal "recommend" which will always
warn but never fail. It's configuration is done by a new element {{recommendations}} which
just holds a sequence of rules.

I extracted most of EnforceMojo to AbstractEnforceMojo to avoid code duplication. I added
an invoker test and all tests ran successfully.

See https://github.com/apache/maven-enforcer/pull/4 as well for easier review.

  was:
In our company's parent POM we define a lot of rules, some of which are controversial or may
not be easily fulfilled. The patch I attach defines a new goal "recommend" which will always
warn but never fail. It's configuration is done by a new element {{recommendations}} which
just holds a sequence of rules.

I extracted most of EnforceMojo to AbstractEnforceMojo to avoid code duplication. I added
an invoker test and all tests ran successfully.

For easy review I created a pull request as well at github, which I will include later on
in a comment.

    
> Add goal recommend which will only warn but never fail a build
> --------------------------------------------------------------
>
>                 Key: MENFORCER-159
>                 URL: https://jira.codehaus.org/browse/MENFORCER-159
>             Project: Maven 2.x Enforcer Plugin
>          Issue Type: New Feature
>          Components: Plugin
>    Affects Versions: 1.3
>            Reporter: Mirko Friedenhagen
>         Attachments: recommend-mojo.patch
>
>
> In our company's parent POM we define a lot of rules, some of which are controversial
or may not be easily fulfilled. The patch I attach defines a new goal "recommend" which will
always warn but never fail. It's configuration is done by a new element {{recommendations}}
which just holds a sequence of rules.
> I extracted most of EnforceMojo to AbstractEnforceMojo to avoid code duplication. I added
an invoker test and all tests ran successfully.
> See https://github.com/apache/maven-enforcer/pull/4 as well for easier review.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message