maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lukasz Strzelecki (JIRA)" <j...@codehaus.org>
Subject [jira] (MRELEASE-826) preparationGoals and git
Date Sat, 23 Feb 2013 12:43:52 GMT

    [ https://jira.codehaus.org/browse/MRELEASE-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=320388#comment-320388
] 

Lukasz Strzelecki commented on MRELEASE-826:
--------------------------------------------

To proof that android sets correct value I have log BEFORE changing AndroidManifest.xml
{code}
[INFO] [INFO] --- android-maven-plugin:3.5.0:manifest-update (default-cli) @ poc-android-release
---
[INFO] [INFO] Attempting to update manifest /home/lstrzeleck/workspace/poc-android-release/AndroidManifest.xml
[INFO] [INFO] Setting android:versionName to 0.0.6
[INFO] [INFO] Made changes to manifest file, updating /home/lstrzeleck/workspace/poc-android-release/AndroidManifest.xml
{code}
                
> preparationGoals and git
> ------------------------
>
>                 Key: MRELEASE-826
>                 URL: https://jira.codehaus.org/browse/MRELEASE-826
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>          Components: Git, prepare
>    Affects Versions: 2.4
>         Environment: Apache Maven 3.0.4
> Java version: 1.6.0_37, vendor: Sun Microsystems Inc.
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "3.5.0-21-generic", arch: "amd64", family: "unix"
>            Reporter: Lukasz Strzelecki
>
> * What I want achieve?
> Before release:prepare process I want change source. Filter some source file and put
release version X.Y.Z (without SNAPSHOT)
> So I configured release plugin with
> <preparationGoals>android:manifest-update</preparationGoals>
> Goal: android:manifest-update change AndroidManifest.xml
> I suppose this change should be applied AFTER change version without SNAPSHOT and BEFORE
commit changes to git repository.
> I see that goal is executed and valid version is propagated. But when I read log for
commit/push commands I see:
> {code}
> [INFO] Not removing release POMs
> [INFO] Checking in modified POMs...
> [INFO] Executing: /bin/sh -c cd /home/lstrzeleck/workspace/poc-android-release &&
git add -- pom.xml
> [INFO] Working directory: /home/lstrzeleck/workspace/poc-android-release
> [INFO] Executing: /bin/sh -c cd /home/lstrzeleck/workspace/poc-android-release &&
git status --porcelain
> [INFO] Working directory: /home/lstrzeleck/workspace/poc-android-release
> [INFO] Executing: /bin/sh -c cd /home/lstrzeleck/workspace/poc-android-release &&
git commit --verbose -F /tmp/maven-scm-1669056864.commit pom.xml
> [INFO] Working directory: /home/lstrzeleck/workspace/poc-android-release
> [INFO] Executing: /bin/sh -c cd /home/lstrzeleck/workspace/poc-android-release &&
git symbolic-ref HEAD
> [INFO] Working directory: /home/lstrzeleck/workspace/poc-android-release
> [INFO] Executing: /bin/sh -c cd /home/lstrzeleck/workspace/poc-android-release &&
git push git@github.com:lstrzelecki/poc-android-release.git master:master
> [INFO] Working directory: /home/lstrzeleck/workspace/poc-android-release
> [INFO] Release preparation complete.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> {code} 
> I think what is missing is that we add ONLY pom.xml
> See this line:
> Executing: /bin/sh -c cd /home/lstrzeleck/workspace/poc-android-release && *git
add -- pom.xml*
> What I expect that plugin should add all files (by ie git add .) 
> If you want some example you can fork github project:
> https://github.com/lstrzelecki/poc-android-release
> It requires android SDK.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message