Return-Path: X-Original-To: apmail-maven-issues-archive@minotaur.apache.org Delivered-To: apmail-maven-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5241CD349 for ; Fri, 28 Sep 2012 06:06:02 +0000 (UTC) Received: (qmail 28927 invoked by uid 500); 28 Sep 2012 06:06:01 -0000 Delivered-To: apmail-maven-issues-archive@maven.apache.org Received: (qmail 28880 invoked by uid 500); 28 Sep 2012 06:06:01 -0000 Mailing-List: contact issues-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list issues@maven.apache.org Received: (qmail 28865 invoked by uid 99); 28 Sep 2012 06:06:01 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Sep 2012 06:06:01 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [63.246.24.159] (HELO codehaus01.managed.contegix.com) (63.246.24.159) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Sep 2012 06:05:56 +0000 Received: from codehaus01 (localhost.localdomain [127.0.0.1]) by codehaus01.managed.contegix.com (Postfix) with ESMTP id 18FE8B048D for ; Fri, 28 Sep 2012 01:05:36 -0500 (CDT) Date: Fri, 28 Sep 2012 01:05:36 -0500 (CDT) From: "Dennis Lundberg (JIRA)" To: issues@maven.apache.org Message-ID: <1944592046.3403.1348812336103.JavaMail.j2ee-jira@codehaus01.managed.contegix.com> In-Reply-To: <4566805.1218006927339.JavaMail.haus-jira@codehaus01.managed.contegix.com> Subject: [jira] (MWAR-164) Support for specifying which encoding to use when filtering resources MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 22cf62d5d84cf5bea94eb3b65e0ebd09 X-Virus-Checked: Checked by ClamAV on apache.org [ https://jira.codehaus.org/browse/MWAR-164?page=3Dcom.atlassian.jira.= plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg closed MWAR-164. -------------------------------- Resolution: Fixed =20 > Support for specifying which encoding to use when filtering resources > --------------------------------------------------------------------- > > Key: MWAR-164 > URL: https://jira.codehaus.org/browse/MWAR-164 > Project: Maven 2.x WAR Plugin > Issue Type: Improvement > Components: filtering > Affects Versions: 2.1-alpha-1 > Reporter: kai lilleby > Assignee: Dennis Lundberg > Fix For: 2.3 > > Attachments: MWAR-164-maven-war-plugin.patch > > > Quoting Herv=E9: > {quote} > Maven filtering provides an encoding parameter to set encoding used when > reading/writing files. But war plugin uses null value, which means platfo= rm > encoding... Sorry, encoding support won't be totally "free" ;) > I added TODOs in the code. > For web.xml and container config XML file, I set encoding to UTF-8, which= is a > better default value than platform encoding. > For other filtered resources, you'll need to add an encoding attribute to > o.a.m.model.Resource class, to let the user define which encoding he want= s to > use when filtering. Perhaps using project.build.sourceEncoding as a defau= lt > value is a good idea. > Seems like this is worth a Jira issue to track this new feature. > {quote} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrato= rs: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira