maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Petr Kozelka (JIRA)" <j...@codehaus.org>
Subject [jira] Created: (SCM-647) SvnChangeLogConsumer parses filename incorrectly when file is copied from existing one
Date Sat, 26 Nov 2011 01:40:39 GMT
SvnChangeLogConsumer parses filename incorrectly when file is copied from existing one
--------------------------------------------------------------------------------------

                 Key: SCM-647
                 URL: https://jira.codehaus.org/browse/SCM-647
             Project: Maven SCM
          Issue Type: Bug
          Components: maven-scm-provider-svn
    Affects Versions: 1.5, 1.6
            Reporter: Petr Kozelka
         Attachments: scm-svn-origfile.patch

Current implementations uses non-xml svn log for gathering information. It always returns
everything after 5th char as the filename, which is a bug in cases like this:
{quote}   A /maven/scm/trunk/maven-scm-test/src/main/java/org/apache/maven/scm/ScmTestCase.java
(from /maven/scm/trunk/maven-scm-api/src/main/java/org/apache/maven/scm/ScmTestCase.java:191665){quote}
which indicate copying a path from existing revision.

Note that this example was taken from the [svnlog2.txt line 510|https://svn.apache.org/viewvc/maven/scm/trunk/maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/test/resources/svn/changelog/svnlog2.txt?view=markup#l510]
file in test resources.

I suggest to fix it with the attached patch. It also enhances tests to assert that the parsed
filenames are correct - not containing spaces and beginning with common path.


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message