Return-Path: 
 <issues-return-73193-apmail-maven-issues-archive=maven.apache.org@maven.apache.org>
X-Original-To: apmail-maven-issues-archive@minotaur.apache.org
Delivered-To: apmail-maven-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id B3A4E63E2
	for <apmail-maven-issues-archive@minotaur.apache.org>;
 Tue,  2 Aug 2011 04:10:44 +0000 (UTC)
Received: (qmail 84817 invoked by uid 500); 2 Aug 2011 04:10:42 -0000
Delivered-To: apmail-maven-issues-archive@maven.apache.org
Received: (qmail 82104 invoked by uid 500); 2 Aug 2011 04:10:19 -0000
Mailing-List: contact issues-help@maven.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@maven.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@maven.apache.org>
List-Post: <mailto:issues@maven.apache.org>
List-Id: <issues.maven.apache.org>
Reply-To: dev@maven.apache.org
Delivered-To: mailing list issues@maven.apache.org
Received: (qmail 82074 invoked by uid 99); 2 Aug 2011 04:10:09 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Aug 2011 04:10:09 +0000
X-ASF-Spam-Status: No, hits=-0.0 required=5.0
	tests=SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (athena.apache.org: local policy)
Received: from [63.246.2.115] (HELO codehaus01.managed.contegix.com)
 (63.246.2.115)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Aug 2011 04:10:04 +0000
Received: from codehaus01.managed.contegix.com (localhost.localdomain
 [127.0.0.1])
	by codehaus01.managed.contegix.com (Postfix) with ESMTP id 3C8AE458488
	for <issues@maven.apache.org>; Mon,  1 Aug 2011 23:09:43 -0500 (CDT)
Date: Mon, 1 Aug 2011 23:09:43 -0500 (CDT)
From: "Chris Whelan (JIRA)" <jira@codehaus.org>
To: issues@maven.apache.org
Message-ID: 
 <4903009.28480.1312258183225.JavaMail.haus-jira@codehaus01.managed.contegix.com>
Subject: [jira] Created: (MCHECKSTYLE-163) Test classpath resolution fails
 in mvn check:check when includeTestSourceDirectory = true
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 22cf62d5d84cf5bea94eb3b65e0ebd09

Test classpath resolution fails in mvn check:check when includeTestSourceDirectory = true
-----------------------------------------------------------------------------------------

                 Key: MCHECKSTYLE-163
                 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-163
             Project: Maven 2.x Checkstyle Plugin
          Issue Type: Bug
    Affects Versions: 2.7
            Reporter: Chris Whelan
         Attachments: resolveTestClasspath.patch

When includeTestSourceDirectory=true is set for maven-checkstyle-plugin, the full test classpath should be made available to checkstyle.  Patch included to resolve issue by setting @requiresDependencyResolution to test.

In DefaultCheckstyleExecutor.java the checker.setClassLoader() is configured using the classpath string from request.getProject().getTestClasspathElements() (see DefaultCheckstyleExecutor line 114).

However, the CheckstyleViolationCheckMojo only has @requiresDependencyResolution compile which means that pom dependencies which have been declared as <scope>test</scope> are not returned by project.getTestClasspathElements().

This is a particular issue for the checkstyle RedundantThrows check (http://checkstyle.sourceforge.net/config_coding.html#RedundantThrows) as it requires all Exceptions to be available on it's classpath.

If code throws an Exception which has been imported from a maven <scope>test</scope> dependency, the exception will not be available on the classpath and this checkstyle check will fail.

Example:

Include junit as a test scope dependency in the project POM:
<dependency>
  <groupId>junit</groupId>
  <artifactId>junit</artifactId>
  <version>${junit.version}</version>
  <scope>test</scope>
</dependency>

Throw any junit exception within project test code, e.g.:
public class MyCustomTestRunner extends BlockJUnit4ClassRunner {
	public MyCustomTestRunner(final Class<?> klass) throws InitializationError {

If RedundantThrows check is enabled, the following error will be thrown:
[INFO] --- maven-checkstyle-plugin:2.7-SNAPSHOT:check (checkstyle-verify) @ sample-project ---
[INFO] Starting audit...
C:\Working\hg\sample-project\src\test\java\com\sample\support\junit\MyCustomTestRunner.java:28:72: warning: Unable to get class information for InitializationError.
Audit done.

[ERROR] MyCustomTestRunner.java[28:72] Unable to get class information for InitializationError.



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira