Return-Path: 
 <issues-return-73201-apmail-maven-issues-archive=maven.apache.org@maven.apache.org>
X-Original-To: apmail-maven-issues-archive@minotaur.apache.org
Delivered-To: apmail-maven-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 5FFA26FC9
	for <apmail-maven-issues-archive@minotaur.apache.org>;
 Tue,  2 Aug 2011 13:56:22 +0000 (UTC)
Received: (qmail 26028 invoked by uid 500); 2 Aug 2011 13:56:22 -0000
Delivered-To: apmail-maven-issues-archive@maven.apache.org
Received: (qmail 25967 invoked by uid 500); 2 Aug 2011 13:56:21 -0000
Mailing-List: contact issues-help@maven.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@maven.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@maven.apache.org>
List-Post: <mailto:issues@maven.apache.org>
List-Id: <issues.maven.apache.org>
Reply-To: dev@maven.apache.org
Delivered-To: mailing list issues@maven.apache.org
Received: (qmail 25956 invoked by uid 99); 2 Aug 2011 13:56:21 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Aug 2011 13:56:21 +0000
X-ASF-Spam-Status: No, hits=-0.0 required=5.0
	tests=SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (nike.apache.org: local policy)
Received: from [63.246.2.115] (HELO codehaus01.managed.contegix.com)
 (63.246.2.115)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Aug 2011 13:56:15 +0000
Received: from codehaus01.managed.contegix.com (localhost.localdomain
 [127.0.0.1])
	by codehaus01.managed.contegix.com (Postfix) with ESMTP id 1B29D45801A
	for <issues@maven.apache.org>; Tue,  2 Aug 2011 08:55:43 -0500 (CDT)
Date: Tue, 2 Aug 2011 08:55:42 -0500 (CDT)
From: "Filip van Laenen (JIRA)" <jira@codehaus.org>
To: issues@maven.apache.org
Message-ID: 
 <3724157.28668.1312293342820.JavaMail.haus-jira@codehaus01.managed.contegix.com>
In-Reply-To: 
 <22799101.84007.1306927582290.JavaMail.haus-jira@codehaus01.managed.contegix.com>
Subject: [jira] Commented: (MCHECKSTYLE-159) Optional treeWalker.cacheFile
 property must not be required
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 22cf62d5d84cf5bea94eb3b65e0ebd09
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://jira.codehaus.org/browse/MCHECKSTYLE-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=274817#comment-274817 ] 

Filip van Laenen commented on MCHECKSTYLE-159:
----------------------------------------------

There's a small type in the Checkstyle configuration: the value of the property should have a capital F like this in order for the work-around to work:

<module name="Checker">
[...]
<module name="TreeWalker">
<property name="cacheFile" value="${cacheFile}"/>
[...]
</module>
[...]
</module>

> Optional treeWalker.cacheFile property must not be required
> -----------------------------------------------------------
>
>                 Key: MCHECKSTYLE-159
>                 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-159
>             Project: Maven 2.x Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.6, 2.7
>            Reporter: Karsten Tinnefeld
>
> Given a custom checkstyle configuration, checkstyle requires the property cacheFile to the TreeWalker module be configured, thus, the following configuration cannot go without the property line:
> <module name="Checker">
>   [...]
>   <module name="TreeWalker">
>     <property name="cacheFile" value="$\{cachefile\}"/>
>     [...]
>   </module>
>   [...]
> </module>
> In case it is omitted, the tool exits with the following stack trace (shortened, regarding version 2.6):
> [INFO] Error during page generation
> Embedded error: Error rendering Maven report: Failed during checkstyle execution
> missing key 'cacheFile' in TreeWalker
> [INFO] ------------------------------------------------------------------------
> [DEBUG] Trace
> org.apache.maven.lifecycle.LifecycleExecutionException: Error during page generation
> 	at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:719)
> 	at 
> [...]
> Caused by: com.puppycrawl.tools.checkstyle.api.CheckstyleException: missing key 'cacheFile' in TreeWalker
> 	at com.puppycrawl.tools.checkstyle.DefaultConfiguration.getAttribute(DefaultConfiguration.java:74)
> 	at org.apache.maven.plugin.checkstyle.DefaultCheckstyleExecutor.getConfiguration(DefaultCheckstyleExecutor.java:270)
> 	... 28 more
> Due to checkstyle documentation, the property is optional, and no cachefile will be used in case it is not specified (cf. http://checkstyle.sourceforge.net/config.html#TreeWalker). Also, cacheFile can be specified in the pom, thus it should be substituted anyway.
> Workaround:
> Add <configuration/>-Entry
>   <propertyExpansion>
>     cacheFile=${project.build.directory}/checkstyle-cachefile
>   </propertyExpansion>
> and use the above property line and a special maven build version of the checkstyle configuration file.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira