Return-Path: 
 <issues-return-73197-apmail-maven-issues-archive=maven.apache.org@maven.apache.org>
X-Original-To: apmail-maven-issues-archive@minotaur.apache.org
Delivered-To: apmail-maven-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 475BF6C48
	for <apmail-maven-issues-archive@minotaur.apache.org>;
 Tue,  2 Aug 2011 12:07:18 +0000 (UTC)
Received: (qmail 64048 invoked by uid 500); 2 Aug 2011 12:07:16 -0000
Delivered-To: apmail-maven-issues-archive@maven.apache.org
Received: (qmail 63763 invoked by uid 500); 2 Aug 2011 12:07:11 -0000
Mailing-List: contact issues-help@maven.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@maven.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@maven.apache.org>
List-Post: <mailto:issues@maven.apache.org>
List-Id: <issues.maven.apache.org>
Reply-To: dev@maven.apache.org
Delivered-To: mailing list issues@maven.apache.org
Received: (qmail 63755 invoked by uid 99); 2 Aug 2011 12:07:10 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Aug 2011 12:07:10 +0000
X-ASF-Spam-Status: No, hits=-0.0 required=5.0
	tests=SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (nike.apache.org: local policy)
Received: from [63.246.2.115] (HELO codehaus01.managed.contegix.com)
 (63.246.2.115)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Aug 2011 12:07:04 +0000
Received: from codehaus01.managed.contegix.com (localhost.localdomain
 [127.0.0.1])
	by codehaus01.managed.contegix.com (Postfix) with ESMTP id B464945848A
	for <issues@maven.apache.org>; Tue,  2 Aug 2011 07:06:42 -0500 (CDT)
Date: Tue, 2 Aug 2011 07:06:42 -0500 (CDT)
From: "Julien HENRY (JIRA)" <jira@codehaus.org>
To: issues@maven.apache.org
Message-ID: 
 <32151547.28602.1312286802736.JavaMail.haus-jira@codehaus01.managed.contegix.com>
In-Reply-To: 
 <23939664.7297.1308909704192.JavaMail.haus-jira@codehaus01.managed.contegix.com>
Subject: [jira] Commented: (MASSEMBLY-561) Encoding is broken when filtering
 is enabled
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 22cf62d5d84cf5bea94eb3b65e0ebd09
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://jira.codehaus.org/browse/MASSEMBLY-561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=274811#comment-274811 ] 

Julien HENRY commented on MASSEMBLY-561:
----------------------------------------

Hi John,

Did you have a chance to complete the review of my patch? Do you still have issue with the integration test?

Thanks

Julien

> Encoding is broken when filtering is enabled
> --------------------------------------------
>
>                 Key: MASSEMBLY-561
>                 URL: https://jira.codehaus.org/browse/MASSEMBLY-561
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2.1
>            Reporter: Julien HENRY
>            Priority: Critical
>         Attachments: MASSEMBLY-561.patch
>
>
> My resources are encoded in ISO-8859-1. I have specified encoding in the pom: 
> {code}<project.build.sourceEncoding>ISO-8859-1</project.build.sourceEncoding>{code}
> I have written a custom assembly file and I am using resource filtering.
> {code}...
> <fileSet>
> 	<directory>${project.basedir}/src/main/resources/</directory>
> 	<outputDirectory>/</outputDirectory>
> 	<filtered>true</filtered>
> </fileSet>
> ...{code}
> As a result all the french characters are broken in the resulting zip assembly. My platform is Linux so the default platform encoding is UTF-8.
> I have checked plugin code and I think I found the issue. This is in FileFormatter.java, method doFileFilter():
> {code}
>             configSource.getMavenFileFilter().copyFile( source, target, true, configSource.getProject(),
>                     configSource.getFilters(), isPropertiesFile, null, configSource.getMavenSession() );
> {code}
> You can see that enconding is set to null, so I think it means using default platform encoding... Would it be possible to use value of project.build.sourceEncoding instead?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira