maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julien HENRY (JIRA)" <>
Subject [jira] Commented: (MASSEMBLY-561) Encoding is broken when filtering is enabled
Date Tue, 02 Aug 2011 12:06:42 GMT


Julien HENRY commented on MASSEMBLY-561:

Hi John,

Did you have a chance to complete the review of my patch? Do you still have issue with the
integration test?



> Encoding is broken when filtering is enabled
> --------------------------------------------
>                 Key: MASSEMBLY-561
>                 URL:
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2.1
>            Reporter: Julien HENRY
>            Priority: Critical
>         Attachments: MASSEMBLY-561.patch
> My resources are encoded in ISO-8859-1. I have specified encoding in the pom: 
> {code}<>ISO-8859-1</>{code}
> I have written a custom assembly file and I am using resource filtering.
> {code}...
> <fileSet>
> 	<directory>${project.basedir}/src/main/resources/</directory>
> 	<outputDirectory>/</outputDirectory>
> 	<filtered>true</filtered>
> </fileSet>
> ...{code}
> As a result all the french characters are broken in the resulting zip assembly. My platform
is Linux so the default platform encoding is UTF-8.
> I have checked plugin code and I think I found the issue. This is in,
method doFileFilter():
> {code}
>             configSource.getMavenFileFilter().copyFile( source, target, true, configSource.getProject(),
>                     configSource.getFilters(), isPropertiesFile, null, configSource.getMavenSession()
> {code}
> You can see that enconding is set to null, so I think it means using default platform
encoding... Would it be possible to use value of instead?

This message is automatically generated by JIRA.
For more information on JIRA, see:


View raw message