maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Casey (JIRA)" <j...@codehaus.org>
Subject [jira] Commented: (MASSEMBLY-561) Encoding is broken when filtering is enabled
Date Mon, 25 Jul 2011 16:47:42 GMT

    [ https://jira.codehaus.org/browse/MASSEMBLY-561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=274147#comment-274147
] 

John Casey commented on MASSEMBLY-561:
--------------------------------------

Hi Julien,

It seems like the ISO-8859-1 test you added in your patch doesn't work, at least not on my
machine (OS X 10.6.8, US English [default?] language settings). The output from the verification
script is:

iso88591.config was not filtered with correct encoding

I'll try to poke around some more later, but for now I just wanted to let you know.

> Encoding is broken when filtering is enabled
> --------------------------------------------
>
>                 Key: MASSEMBLY-561
>                 URL: https://jira.codehaus.org/browse/MASSEMBLY-561
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2.1
>            Reporter: Julien HENRY
>            Priority: Critical
>         Attachments: MASSEMBLY-561.patch
>
>
> My resources are encoded in ISO-8859-1. I have specified encoding in the pom: 
> {code}<project.build.sourceEncoding>ISO-8859-1</project.build.sourceEncoding>{code}
> I have written a custom assembly file and I am using resource filtering.
> {code}...
> <fileSet>
> 	<directory>${project.basedir}/src/main/resources/</directory>
> 	<outputDirectory>/</outputDirectory>
> 	<filtered>true</filtered>
> </fileSet>
> ...{code}
> As a result all the french characters are broken in the resulting zip assembly. My platform
is Linux so the default platform encoding is UTF-8.
> I have checked plugin code and I think I found the issue. This is in FileFormatter.java,
method doFileFilter():
> {code}
>             configSource.getMavenFileFilter().copyFile( source, target, true, configSource.getProject(),
>                     configSource.getFilters(), isPropertiesFile, null, configSource.getMavenSession()
);
> {code}
> You can see that enconding is set to null, so I think it means using default platform
encoding... Would it be possible to use value of project.build.sourceEncoding instead?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message