maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron Digulla (JIRA)" <j...@codehaus.org>
Subject [jira] Commented: (DOXIA-431) Doxia creates illegal URLs from local paths
Date Tue, 24 May 2011 08:10:22 GMT

    [ http://jira.codehaus.org/browse/DOXIA-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=268284#action_268284
] 

Aaron Digulla commented on DOXIA-431:
-------------------------------------

> Doxia 1.2 is not used...

I had problems with the site plugin 3.0-beta-3, so I tried beta-4-SNAPSHOT.

> Is this a regression?

Probably. My guess is that recent code changes unveiled a whole set of errors.

> where does this image come from...

The image comes from the folder {{src/site/resources/images/}}

I'm not the maintainer of the project, so I have no idea how Doxia includes the image. All
I have is the error message and the filename. I can't see any reference to the image in site.xml,
so it must be included from somewhere else, probably the skin.

> Is it documented somewhere that image/file references...?

A URL can contain only some characters. See http://www.blooberry.com/indexdot/html/topics/urlencoding.htm
for a pretty good explanation.

File names on Unix can contain anything except "/" (slash) and 0-bytes. 

So if you accept Unix file names anywhere in Doxia, you must escape them as soon as they are
converted to URLs and you must unescape them when they are converted back to file names.

My suggestion is a new type which can be both and which has accessor methods to get a OS-specific
path or a RFC-compliant URL and to get rid of the type String as soon as you can to make sure
you don't have any gaps in the chain.



> Doxia creates illegal URLs from local paths
> -------------------------------------------
>
>                 Key: DOXIA-431
>                 URL: http://jira.codehaus.org/browse/DOXIA-431
>             Project: Maven Doxia
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.2
>            Reporter: Aaron Digulla
>
> If a local resource contains characters which are illegal in a URL, Doxia creates illegal
code or crashes.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message