maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeroen Ruijgers (JIRA)" <j...@codehaus.org>
Subject [jira] Commented: (MEAR-113) The default contextRoot should match the default bundleFileName
Date Fri, 10 Sep 2010 09:45:33 GMT

    [ http://jira.codehaus.org/browse/MEAR-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=234876#action_234876
] 

Jeroen Ruijgers commented on MEAR-113:
--------------------------------------

This patch breakes today's behaviour when the buildname is not modified. In that case the
version number and classifier (if present) are included in de buildname.
The current behaviour is better, because you get a repeatable deployement, where the context
root is always the same, regardles of the deployed version of the war file.

> The default contextRoot should match the default bundleFileName
> ---------------------------------------------------------------
>
>                 Key: MEAR-113
>                 URL: http://jira.codehaus.org/browse/MEAR-113
>             Project: Maven 2.x Ear Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.3.2
>            Reporter: Michael Semb Wever
>             Fix For: 2.5
>
>         Attachments: MEAR-113.patch, MEAR-113.patch
>
>
> In a webModule the contextRoot defaults to 
>  "/" + a.getArtifactId()
> There is no way AFAIK to have a contextRoot that honours the webModule artifact's finalName,
necessary if it was dynamically set via profiles.
> (The only way i see here is to duplicate all the profile information and put the maven-ear-plugin
configuration into each profile, just to insert the various contextRoot values).
> By making the contextRoot instead default to 
>  "/" + getBundleFileName()
> this scenario is solved. 
> The webModule's contextRoot defaults to the build name of the artifact if it were customised.
If that artifact's finalName was not customised then it defaults back to the artifactId therefore
maintaining today's behavior and not breaking any compatibility.
> Patch attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message