maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Springer (JIRA)" <j...@codehaus.org>
Subject [jira] Commented: (MNG-4583) warning printed when a pom does not use an activated profile is poorly worded and also should not be printed for multi-module builds
Date Wed, 10 Mar 2010 14:28:55 GMT

    [ http://jira.codehaus.org/browse/MNG-4583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=213355#action_213355
] 

Ian Springer commented on MNG-4583:
-----------------------------------

> [WARNING] The requested profile "foo" could not be activated because it does not exist.

I don't agree that this is clarified. 

Based on my understanding on Maven terminology, "foo" *is* activated in the reactor. It's
just not referenced in the pom currently being processed, which is the point of this warning.
When building a single module, there's a good chance this is a mistake/typo in the user's
settings.xml or mvn command line. For a multi-module build, it is common to activate a profile
"foo" that may only be referenced in some of the modules in the reactor, so in that case,
I don't think the warning should be printed at all, or maybe it should be printed as an INFO
or DEBUG message, rather than a WARN.



> warning printed when a pom does not use an activated profile is poorly worded and also
should not be printed for multi-module builds
> ------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MNG-4583
>                 URL: http://jira.codehaus.org/browse/MNG-4583
>             Project: Maven 2 & 3
>          Issue Type: Bug
>          Components: Profiles
>    Affects Versions: 2.0.11, 2.2.1, 3.0-alpha-6
>            Reporter: Ian Springer
>            Assignee: Benjamin Bentmann
>            Priority: Minor
>             Fix For: 3.0-alpha-6
>
>
> This is a followup to http://jira.codehaus.org/browse/MNG-3641. Refer to that issue for
the background.
> The current warning message is:
> "Profile with id: '" + explicitProfileId + "' has not been activated."
> I think this message is misleading, because the profile actually is activated - it's
just not used at all in the pom being processed. I suggest changing the message to something
like:
> "Profile with id '" + explicitProfileId + "' is activated, but this pom does not contain
any usages of the profile."
> Also, I don't think it makes sense to print this warning at all in a multi-module build.
In the large multi-module project I work on, we have a number of profiles that are only used
in a handful of the 50 or so modules.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message