Return-Path: 
 <issues-return-60442-apmail-maven-issues-archive=maven.apache.org@maven.apache.org>
Delivered-To: apmail-maven-issues-archive@minotaur.apache.org
Received: (qmail 86884 invoked from network); 16 Jan 2010 00:29:28 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3)
  by minotaur.apache.org with SMTP; 16 Jan 2010 00:29:28 -0000
Received: (qmail 12487 invoked by uid 500); 16 Jan 2010 00:29:28 -0000
Delivered-To: apmail-maven-issues-archive@maven.apache.org
Received: (qmail 12400 invoked by uid 500); 16 Jan 2010 00:29:28 -0000
Mailing-List: contact issues-help@maven.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@maven.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@maven.apache.org>
List-Post: <mailto:issues@maven.apache.org>
List-Id: <issues.maven.apache.org>
Reply-To: dev@maven.apache.org
Delivered-To: mailing list issues@maven.apache.org
Received: (qmail 12390 invoked by uid 99); 16 Jan 2010 00:29:28 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 16 Jan 2010 00:29:28 +0000
X-ASF-Spam-Status: No, hits=-0.0 required=10.0
	tests=SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (nike.apache.org: local policy)
Received: from [63.246.2.115] (HELO codehaus01.managed.contegix.com)
 (63.246.2.115)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 16 Jan 2010 00:29:17 +0000
Received: from codehaus01.managed.contegix.com (localhost.localdomain
 [127.0.0.1])
	by codehaus01.managed.contegix.com (Postfix) with ESMTP id A3A3E14A8242
	for <issues@maven.apache.org>; Fri, 15 Jan 2010 18:28:55 -0600 (CST)
Date: Fri, 15 Jan 2010 18:28:55 -0600 (CST)
From: "Patrick Woodworth (JIRA)" <jira@codehaus.org>
To: issues@maven.apache.org
Message-ID: 
 <31643861.64178.1263601735661.JavaMail.haus-jira@codehaus01.managed.contegix.com>
In-Reply-To: 
 <12263731.1204636228578.JavaMail.haus-jira@codehaus01.managed.contegix.com>
Subject: [jira] Updated: (MASSEMBLY-289) Fix bogus warning about attaching
 non-regular file
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 4e90ceb663894a42f12c0e28abbab431
X-Virus-Checked: Checked by ClamAV on apache.org


     [ http://jira.codehaus.org/browse/MASSEMBLY-289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Woodworth updated MASSEMBLY-289:
----------------------------------------

    Attachment: trunk-r899849.patch

Attaching an updated patch to fix this issue rebased off latest trunk (now a one-liner).

> Fix bogus warning about attaching non-regular file
> --------------------------------------------------
>
>                 Key: MASSEMBLY-289
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-289
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2-beta-2
>            Reporter: Benjamin Bentmann
>            Priority: Trivial
>         Attachments: bogus-attach-warning.patch, trunk-r899849.patch
>
>
> If an archive file is configured with attach=false, the plugin will output the following warning because the underlying if-else is wrong:
> {noformat}
> [WARNING] Assembly file: <snip>.zip is not a regular file (it may be a directory).
>   It cannot be attached to the project build for installation or deployment.
> {noformat}
> The warning must be guarded with attach=true.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira