maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Herve Boutemy (JIRA)" <j...@codehaus.org>
Subject [jira] Closed: (MNG-3266) maven-model RepositoryBase overrides equals() but not hashCode()
Date Fri, 01 Jan 2010 23:10:55 GMT

     [ http://jira.codehaus.org/browse/MNG-3266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Herve Boutemy closed MNG-3266.
------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 2.2.x)
                   3.0-alpha-6
                   2.2.2
         Assignee: Herve Boutemy

patch applied in r895088 for 2.2.x branch and r895089 for 3.0.x
thank you

> maven-model RepositoryBase overrides equals() but not hashCode()
> ----------------------------------------------------------------
>
>                 Key: MNG-3266
>                 URL: http://jira.codehaus.org/browse/MNG-3266
>             Project: Maven 2 & 3
>          Issue Type: Bug
>    Affects Versions: 2.0.7
>            Reporter: Jared Roberts
>            Assignee: Herve Boutemy
>            Priority: Minor
>             Fix For: 2.2.2, 3.0-alpha-6
>
>         Attachments: MNG-3266-maven-model-v2.patch, MNG-3266-maven-model.patch
>
>
> Overriding equals and not hashCode is considered bad practice. Also, while looking around,
I noticed the two subclasses (Repository and PluginRepository) both override equals and just
call "super.equals()". There is a cryptic comment nearby that leads me to believe this is
a temporary fix for an old problem.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message