Mailing-List: contact issues-help@maven.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@maven.apache.org
Received-SPF: pass (nike.apache.org: local policy)
Date: Mon, 7 Dec 2009 08:04:55 -0600 (CST)
From: =?ISO-8859-1?Q?Tam=E1s_Cserven=E1k_=28JIRA=29?= <jira@codehaus.org>
To: issues@maven.apache.org
Message-ID: 
 <29574553.28638.1260194695324.JavaMail.haus-jira@codehaus01.managed.contegix.com>
In-Reply-To: 
 <13855261.1211960123461.JavaMail.haus-jira@codehaus01.managed.contegix.com>
Subject: [jira] Commented: (MNG-4368) DefaultArtifactInstaller should only
 overwrite files if timestamp has changed
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable


    [ http://jira.codehaus.org/browse/MNG-4368?page=3Dcom.atlassian.jira.pl=
ugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D201551#actio=
n_201551 ]=20

Tam=E1s Cserven=E1k commented on MNG-4368:
--------------------------------------

This is _completely wrong_, and makes Maven3 very cumbersome (if not comple=
tely broken) to work on branches, especially with regarding POMs. What happ=
ens:

Check out a trunk of your project (let's suppose all files are modified tod=
ay T0):

* svn checkout
* mvn clean install

Then, tomorrow T1 do a branch of your project, and _modify_ for example the=
 POM of your project in branch.

* svn branch it
* mvn clean install

Then, next day T2, return to trunk and continue work (but for example's sak=
e, do _not_ modify the POM you changed in branch).

* svn switch back to trunk
* mvn clean instal

Obviously T0 < T1 < T2

But, the change done in T1 will be _*not replaceable*_ by the 2nd trunk bui=
ld (mvn clean install in T2 will *NOT* replace the pom in local repo), and =
potentionally will result in very spurious errors (ie. in branch you remove=
/add deps, change parent, etc).

Please, undo this! Thanks.

Interestingly, this will fit nicely with Git (git will "touch" the file whe=
n switching back from branch to "master")
http://git.or.cz/gitwiki/GitSvnComparsion
http://git.or.cz/gitwiki/GitFaq#Whyisn.27tGitpreservingmodificationtimeonfi=
les.3F

But in general, on "install" goal Maven should install the files I told it =
to install.


> DefaultArtifactInstaller should only overwrite files if timestamp has cha=
nged
> -------------------------------------------------------------------------=
----
>
>                 Key: MNG-4368
>                 URL: http://jira.codehaus.org/browse/MNG-4368
>             Project: Maven 2
>          Issue Type: Improvement
>         Environment: Linux, JDK 1.5
>            Reporter: Johannes Martin
>             Fix For: 2.2.2, 3.0-alpha-3
>
>
> install:install (from maven-install-plugin) by default uses DefaultArtifa=
ctInstaller to install artifacts. DefaultArtifactInstaller in turn uses Fil=
eUtils.copyFile(), thereby overwriting destination files even if they are u=
nchanged. It would be helpful if DefaultArtifactInstaller used FileUtils.co=
pyFileIfModified() instead, at least as an option, to speed up the build pr=
ocess.

--=20
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: htt=
p://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira