Return-Path: 
 <issues-return-58741-apmail-maven-issues-archive=maven.apache.org@maven.apache.org>
Delivered-To: apmail-maven-issues-archive@minotaur.apache.org
Received: (qmail 95463 invoked from network); 26 Nov 2009 14:01:25 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3)
  by minotaur.apache.org with SMTP; 26 Nov 2009 14:01:25 -0000
Received: (qmail 29225 invoked by uid 500); 26 Nov 2009 14:01:24 -0000
Delivered-To: apmail-maven-issues-archive@maven.apache.org
Received: (qmail 29156 invoked by uid 500); 26 Nov 2009 14:01:24 -0000
Mailing-List: contact issues-help@maven.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@maven.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@maven.apache.org>
List-Post: <mailto:issues@maven.apache.org>
List-Id: <issues.maven.apache.org>
Reply-To: dev@maven.apache.org
Delivered-To: mailing list issues@maven.apache.org
Received: (qmail 29146 invoked by uid 99); 26 Nov 2009 14:01:24 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Nov 2009 14:01:24 +0000
X-ASF-Spam-Status: No, hits=-2.9 required=5.0
	tests=AWL,BAYES_00
X-Spam-Check-By: apache.org
Received-SPF: pass (athena.apache.org: local policy)
Received: from [63.246.2.115] (HELO codehaus01.managed.contegix.com)
 (63.246.2.115)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Nov 2009 14:01:20 +0000
Received: from codehaus01.managed.contegix.com (localhost.localdomain
 [127.0.0.1])
	by codehaus01.managed.contegix.com (Postfix) with ESMTP id 901DE17E06C9
	for <issues@maven.apache.org>; Thu, 26 Nov 2009 08:00:59 -0600 (CST)
Date: Thu, 26 Nov 2009 08:00:59 -0600 (CST)
From: "Dennis Lundberg (JIRA)" <jira@codehaus.org>
To: issues@maven.apache.org
Message-ID: 
 <19032784.20179.1259244059279.JavaMail.haus-jira@codehaus01.managed.contegix.com>
In-Reply-To: 
 <10464116.18138.1259075935450.JavaMail.haus-jira@codehaus01.managed.contegix.com>
Subject: [jira] Closed: (MCHANGES-186) Issue links for JIRA are broken when
 using the %URL% token
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 4e90ceb663894a42f12c0e28abbab431


     [ http://jira.codehaus.org/browse/MCHANGES-186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg closed MCHANGES-186.
------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.3
         Assignee: Dennis Lundberg

Fixed in [r884559|http://svn.apache.org/viewvc?view=rev&revision=884559].

> Issue links for JIRA are broken when using the %URL% token
> ----------------------------------------------------------
>
>                 Key: MCHANGES-186
>                 URL: http://jira.codehaus.org/browse/MCHANGES-186
>             Project: Maven 2.x Changes Plugin
>          Issue Type: Bug
>          Components: changes-report
>    Affects Versions: 2.2
>            Reporter: Dennis Lundberg
>            Assignee: Dennis Lundberg
>             Fix For: 2.3
>
>
> The fix for MCHANGES-166 included a small change that broke this. See http://jira.codehaus.org/browse/MCHANGES-166?focusedCommentId=184918&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_184918
> {quote}
> The private method parseIssueLink(...) should remove only the trailing slash from the URL if one exists. This prevents cases where we miss to give a trailing slash in the issueManagement.url.
> {quote}
> This part of the patch should not have been committed. The documentation for the issueLinkTemplatePerSystem parameter states:
> {quote}
> %URL%: this is computed by getting the <issueManagement>/<url> value from the POM, and removing the last '/' and everything that comes after it.
> {quote}
> After the patch this is no longer true. This breaks issue links to JIRA if you have a configuration like this:
> {code:xml}
>   <issueManagement>
>     <system>JIRA</system>
>     <url>http://jira.mycompany.com/browse/PRODUCT</url>
>   </issueManagement>
>   <reporting>
>     <plugins>
>       <plugin>
>         <groupId>org.apache.maven.plugins</groupId>
>         <artifactId>maven-changes-plugin</artifactId>
>         <version>2.2</version>
>         <configuration>
>           <issueLinkTemplatePerSystem>
>             <default>%URL%/%ISSUE%</default>
>           </issueLinkTemplatePerSystem>
>         </configuration>
>       </plugin>
>     </plugins>
>   </reporting>
> {code}

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira