maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andre Doherty (JIRA)" <j...@codehaus.org>
Subject [jira] Created: (MECLIPSE-618) MANIFEST files generated by plugin are empty when they shouldnt
Date Thu, 12 Nov 2009 17:04:55 GMT
MANIFEST files generated by plugin are empty when they shouldnt
---------------------------------------------------------------

                 Key: MECLIPSE-618
                 URL: http://jira.codehaus.org/browse/MECLIPSE-618
             Project: Maven 2.x Eclipse Plugin
          Issue Type: Bug
          Components: M2Eclipse support
    Affects Versions: 2.7
         Environment: Any
            Reporter: Andre Doherty


MANIFEST.MF files generated by the plugin are empty, therefore a correct deployment of an
EAR project on an application server such as JBoss will fail with classloading issues. 

After a close look at the source code the problem comes from the fact that the dependencies
resolving is disabled in the mojo, in order to not feed the .classpath, but having this side-effect.

I suggest resolving dependencies in any case, and adding a property instead to filter dependencies
in the .classpath generation. 
therefore : 
1: add boolean property to EclipsePlugin : ignoreDeps
2: add boolean property to EclipseWriterConfig : ignoreDeps
3: in M2EclipseMojo>>setupExtra() : 
  - //setResolveDependencies( false );
  - setIgnoreDeps(true);
4: in EclipsePlugin>>createEclipseWriterConfig(IdeDependency[]) : 
  - call config.setIgnoreDeps(isIgnoreDeps());
5: in EclipseClasspathWriter>>write() : 
  - test against if (!config.isIgnoreDeps()) around lines 348 to 387 in order to skip writing
of M2_REPO... dependencies

Tested here, works like a charm






-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message