maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Rohe (JIRA)" <j...@codehaus.org>
Subject [jira] Commented: (MECLIPSE-449) Facet Generation generates duplicate entries - breaks RAD/RSA support
Date Tue, 03 Nov 2009 07:36:55 GMT

    [ http://jira.codehaus.org/browse/MECLIPSE-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=196952#action_196952
] 

Daniel Rohe commented on MECLIPSE-449:
--------------------------------------

The cause of this bug is the creation of the facet file for WTP 1.5 and above. This file contains
entries for fixed facets, the server runtime and installed facets of a project. The fixed
facets depend on the project type and can easily be added during the creation. For the installed
facets the handling currently uses the dependencies and looks for the servlet-api to determine
the version of the jst.web facet. So one solution is to add the dependency javax.servlet:servlet-api:2.x
to the pom and it works or e.g. use the patch and override the installed facets using the
additional facets configuration element.

There is still a bug when working with RAD because the extended and coexistence facets are
only added to ear-projects but also need to be added to war-projects and the handling of the
server runtime is somewhat buggy.

> Facet Generation generates duplicate entries - breaks RAD/RSA support
> ---------------------------------------------------------------------
>
>                 Key: MECLIPSE-449
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-449
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: Bug
>          Components: WTP support
>    Affects Versions: 2.5.1
>         Environment: WinXP, IBM RSA V7.0.0.6 (Eclipse 3.2.2)
>            Reporter: Chris Graham
>             Fix For: 2.8
>
>         Attachments: MECLIPSE-449.patch
>
>
> Using V2.5.1 of the maven-eclipse-plugin, I have some issues in getting the generated
artifacts being correct.
> Take this section of the POM:
> <additionalProjectFacets>
>     <jst.java>5.0</jst.java>
>     <jst.ejb>2.1</jst.ejb>
>     <com.ibm.websphere.extended.ejb>6.1</com.ibm.websphere.extended.ejb>
> </additionalProjectFacets>
> Generates this:
> <faceted-project>
>   <fixed facet="jst.java"/>
>   <fixed facet="jst.utility"/>
>   <installed facet="jst.utility" version="1.0"/>
>   <installed facet="jst.java" version="5.0"/>
>   <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
>   <installed facet="jst.ejb" version="2.1"/>
>   <installed facet="jst.java" version="5.0"/>
> </faceted-project>
> You'll see that the jst.java facet is in there twice.
> Removing the facet from the list:
> <additionalProjectFacets>
>     <jst.ejb>2.1</jst.ejb>
>     <com.ibm.websphere.extended.ejb>6.1</com.ibm.websphere.extended.ejb>
> </additionalProjectFacets>
> Generates this:
> <faceted-project>
>   <fixed facet="jst.java"/>
>   <fixed facet="jst.utility"/>
>   <installed facet="jst.utility" version="1.0"/>
>   <installed facet="jst.java" version="5.0"/>
>   <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
>   <installed facet="jst.ejb" version="2.1"/>
> </faceted-project>
> Which is a little more correct.
> I consider this a bug, as the facets (by their very definition) are unique and should
not be repeated.
> Additionally, when compared to a RSA (V7) generated one, it is missing the standard XML
header:
> <?xml version="1.0" encoding="UTF-8"?>
> Also, where does the jst.utility facet come from?
> It's inclusion is getting in the way of RSA recognising it as a true J2EE component project
(the EJB Deployment descriptor tree element does not display in the Project Explorer view
in the J2EE Perspective).
> This is the complete RSA generated one, for reference:
> <?xml version="1.0" encoding="UTF-8"?>
> <faceted-project>
>   <runtime name="WebSphere Application Server v6.1"/>
>   <fixed facet="jst.ejb"/>
>   <fixed facet="jst.java"/>
>   <installed facet="jst.ejb" version="2.1"/>
>   <installed facet="jst.java" version="5.0"/>
>   <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
> </faceted-project>
> (Which raises another question, how do we specify the runtime items and if something
is fixed or not?)
> However, to get it to be correctly recognised, all we need is this:
> <faceted-project>
>   <fixed facet="jst.java"/>
>   <installed facet="jst.java" version="5.0"/>
>   <installed facet="jst.ejb" version="2.1"/>
>   <installed facet="com.ibm.websphere.extended.ejb" version="6.1"/>
> </faceted-project>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message