maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ognjen Blagojevic (JIRA)" <j...@codehaus.org>
Subject [jira] Commented: (MWAR-164) Support for specifying which encoding to use when filtering resources
Date Wed, 12 Aug 2009 15:23:59 GMT

    [ http://jira.codehaus.org/browse/MWAR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=186839#action_186839
] 

Ognjen Blagojevic commented on MWAR-164:
----------------------------------------

Herve is right. "Perhaps using project.build.sourceEncoding as a default value is a good idea."

Plus a Boolean parameter (searchEncodingInFiles) which will specify to open XML/JSP/HTML...
files to look for specified encoding. This is of course harder to implement and less valuable,
so maybe could be separate bug?

project.build.sourceEncoding covers most use cases, I think.

Regards,
Ognjen

> Support for specifying which encoding to use when filtering resources
> ---------------------------------------------------------------------
>
>                 Key: MWAR-164
>                 URL: http://jira.codehaus.org/browse/MWAR-164
>             Project: Maven 2.x WAR Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.1-alpha-1
>            Reporter: kai lilleby
>             Fix For: 2.1
>
>
> Quoting Hervé:
> {quote}
> Maven filtering provides an encoding parameter to set encoding used when
> reading/writing files. But war plugin uses null value, which means platform
> encoding... Sorry, encoding support won't be totally "free" ;)
> I added TODOs in the code.
> For web.xml and container config XML file, I set encoding to UTF-8, which is a
> better default value than platform encoding.
> For other filtered resources, you'll need to add an encoding attribute to
> o.a.m.model.Resource class, to let the user define which encoding he wants to
> use when filtering. Perhaps using project.build.sourceEncoding as a default
> value is a good idea.
> Seems like this is worth a Jira issue to track this new feature.
> {quote}

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message