maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Edwin Punzalan (JIRA)" <j...@codehaus.org>
Subject [jira] Closed: (MASSEMBLY-385) Filtering replaces tokens it should not be replacing
Date Thu, 20 Aug 2009 17:58:41 GMT

     [ http://jira.codehaus.org/browse/MASSEMBLY-385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Edwin Punzalan closed MASSEMBLY-385.
------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.2-beta-5

Fixed in SVN.

One test is split into two to test an improved behavior.  The original test does not expect
property values containing colons (:) and backslashes (\) to be escaped when the file being
filtered is a properties file which is now being done by maven-filtering.

A test is also added relating to this issue.

> Filtering replaces tokens it should not be replacing
> ----------------------------------------------------
>
>                 Key: MASSEMBLY-385
>                 URL: http://jira.codehaus.org/browse/MASSEMBLY-385
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2-beta-3
>         Environment: Maven 2.0.9
>            Reporter: Robert Bracewell
>            Assignee: Edwin Punzalan
>             Fix For: 2.2-beta-5
>
>         Attachments: component.zip
>
>
> What is described below is attached as an example that duplicates this
> When filtering is turned on and a token ends with .url then very strange things happen
> The assembly descriptor uses
>    <files>
>       <file>
>          <source>${basedir}/src/config/xml/applicationContext.xml</source>
>          <outputDirectory>xml</outputDirectory>
>          <filtered>true</filtered>
>       </file>
>    </files>
> The file being filtered contains:
> <beans>
> 	<bean id="ThisIsATest">
>                 <property name="wapURLMessage" value="${wap.url.message}"/>
>                 <property name="wapURL" value="${wap.url}"/>
>                 <property name="vanityURLMessage" value="${vanity.url.message}"/>
>                 <property name="vanityURL" value="${vanity.url}"/>
> 	</bean>
> </beans>
> After the assembly is run the file contains:
> <beans>
> 	<bean id="ThisIsATest">
>                 <property name="wapURLMessage" value="${wap.url.message}"/>
>                 <property name="wapURL" value="This is a not a URL but demonstrates
the BUG/test1"/>
>                 <property name="vanityURLMessage" value="${vanity.url.message}"/>
>                 <property name="vanityURL" value="This is a not a URL but demonstrates
the BUG/test1"/>
> 	</bean>
> </beans>
> The string This is a not a URL but demonstrates the BUG comes from the url tag defined
in parent pom
> The string test1 is the artifactId

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message