Return-Path: 
 <issues-return-51978-apmail-maven-issues-archive=maven.apache.org@maven.apache.org>
Delivered-To: apmail-maven-issues-archive@minotaur.apache.org
Received: (qmail 2877 invoked from network); 15 Apr 2009 04:44:39 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3)
  by minotaur.apache.org with SMTP; 15 Apr 2009 04:44:39 -0000
Received: (qmail 76100 invoked by uid 500); 15 Apr 2009 04:44:38 -0000
Delivered-To: apmail-maven-issues-archive@maven.apache.org
Received: (qmail 76023 invoked by uid 500); 15 Apr 2009 04:44:38 -0000
Mailing-List: contact issues-help@maven.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@maven.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@maven.apache.org>
List-Post: <mailto:issues@maven.apache.org>
List-Id: <issues.maven.apache.org>
Reply-To: dev@maven.apache.org
Delivered-To: mailing list issues@maven.apache.org
Received: (qmail 76013 invoked by uid 99); 15 Apr 2009 04:44:38 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Apr 2009 04:44:38 +0000
X-ASF-Spam-Status: No, hits=-0.0 required=10.0
	tests=SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (athena.apache.org: local policy)
Received: from [63.246.2.115] (HELO codehaus01.managed.contegix.com)
 (63.246.2.115)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Apr 2009 04:44:30 +0000
Received: from codehaus01.managed.contegix.com (localhost.localdomain
 [127.0.0.1])
	by codehaus01.managed.contegix.com (Postfix) with ESMTP id 37A5D15E8062
	for <issues@maven.apache.org>; Tue, 14 Apr 2009 23:44:13 -0500 (CDT)
Message-ID: 
 <7031477.1239770652912.JavaMail.haus-jira@codehaus01.managed.contegix.com>
Date: Tue, 14 Apr 2009 23:44:12 -0500 (CDT)
From: "Timothy Riley (JIRA)" <jira@codehaus.org>
To: issues@maven.apache.org
Subject: [jira] Commented: (WAGON-258) SSH / SCP -o options should be quoted
In-Reply-To: 
 <10386096.1239770532998.JavaMail.haus-jira@codehaus01.managed.contegix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 4e90ceb663894a42f12c0e28abbab431
X-Virus-Checked: Checked by ClamAV on apache.org


    [ http://jira.codehaus.org/browse/WAGON-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=172999#action_172999 ] 

Timothy Riley commented on WAGON-258:
-------------------------------------

Brett Porter 
Has suggested the following workarounds...

One quick workaround might be to put an intervening script in between  
maven and the PATH that corrects the problem, something like: http://blogs.exist.com/bporter/2008/02/25/working-around-non-interactive-problems-in-leopards-subversion/

> My other option and my prefered option is to
> submit a patch that gets rolled into the nightly build of the wagon
> provider.

This would be best - certainly submit the issue and patch to be rolled  
in. Adding the quotes is not harmful to openssh, so I'd say it's ok to  
add them for all cases.

I wouldn't recommend using a snapshot though - instead it's best if  
you release the library internally (1.0-beta-5-MYCOMPANY-1) and use  
that. This assumes you've set up your own repository and the builds  
all use it.

Adding the following will then override the Maven one:
<build>
   <extensions>
     <extension>
       <groupId>org.apache.maven.wagon</groupId>
       <artifactId>wagon-ssh-external</artifactId>
       <version>1.0-beta-5-MYCOMPANY-1</version>
     </extension>
   </extensions>
</build>

Once the Wagon is formally released you can replace the version with  
the new one.

Cheers,
Brett 

> SSH / SCP -o options should be quoted
> -------------------------------------
>
>                 Key: WAGON-258
>                 URL: http://jira.codehaus.org/browse/WAGON-258
>             Project: Maven Wagon
>          Issue Type: Bug
>          Components: wagon-ssh-external
>    Affects Versions: 1.0-beta-5
>         Environment: Maven 2.1.0 and Java 1.5.0_15
>            Reporter: Timothy Riley
>
> I'm currently using Reflection Secure IT, which requires all SSH / SCP -o options
> be placed in quotations unfortunately I cannot deviate from this technology.
> The problem is that ScpExternalWagon.java places the BatchMode option as an
> argument without quotes resulting in a failing SSH command.
> Line 251 of ScpExternalWagon.java
>    cl.createArgument().setValue( "BatchMode yes" );
> Results in...
> ssh -o BatchMode yes [REST OF COMMAND]
> What I need is...
> ssh -o "BatchMode yes" [REST OF COMMAND]

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira