maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Riley (JIRA)" <j...@codehaus.org>
Subject [jira] Commented: (WAGON-258) SSH / SCP -o options should be quoted
Date Wed, 15 Apr 2009 05:05:13 GMT

    [ http://jira.codehaus.org/browse/WAGON-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=173001#action_173001
] 

Timothy Riley commented on WAGON-258:
-------------------------------------

Brett
I have tested the suggested workaround by building my own 1.0-beta-5-MYCOMPANY-1 version of
the wagon-ssh-external with the quotation fix but this does not work.

Steps I followed:
  1. Extracted wagon-ssh-external-1.0-beta-5-source.jar
  2. Modified ScpExternalWagon line 251 to correct the quotation issue
  3. Copied wagon-ssh-external-1.0-beta-5.pom to pom.xml and modified the version to 1.0-beta-5-MYCOMPANY-1
  4. Modified my demo project pom file with the suggestion in the workaround
  5. Executed mvnDebug -X deploy

The result is my code is never executed even though maven debug clearly says it is selected
for runtime. My theory is that there is a classloading issue. With the release of maven-2.1.0
the maven-2.1.0-uber.jar came packaged with wagon ssh external. Because of this the ScpExternalWagon
in maven-2.1.0-uber.jar is used over my version.

I hope my theory turns out to be incorrect because this would mean wagon ssh external could
not be updated without updating maven.

Thanks
Tim

> SSH / SCP -o options should be quoted
> -------------------------------------
>
>                 Key: WAGON-258
>                 URL: http://jira.codehaus.org/browse/WAGON-258
>             Project: Maven Wagon
>          Issue Type: Bug
>          Components: wagon-ssh-external
>    Affects Versions: 1.0-beta-5
>         Environment: Maven 2.1.0 and Java 1.5.0_15
>            Reporter: Timothy Riley
>
> I'm currently using Reflection Secure IT, which requires all SSH / SCP -o options
> be placed in quotations unfortunately I cannot deviate from this technology.
> The problem is that ScpExternalWagon.java places the BatchMode option as an
> argument without quotes resulting in a failing SSH command.
> Line 251 of ScpExternalWagon.java
>    cl.createArgument().setValue( "BatchMode yes" );
> Results in...
> ssh -o BatchMode yes [REST OF COMMAND]
> What I need is...
> ssh -o "BatchMode yes" [REST OF COMMAND]

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message