maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anders Hammar (JIRA)" <j...@codehaus.org>
Subject [jira] Updated: (MRELEASE-386) Sneaky bug in DefaultReleaseManager.perform()
Date Wed, 12 Nov 2008 12:05:17 GMT

     [ http://jira.codehaus.org/browse/MRELEASE-386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Anders Hammar updated MRELEASE-386:
-----------------------------------

    Attachment: MRELEASE-386-patch.diff

Patch added.

> Sneaky bug in DefaultReleaseManager.perform()
> ---------------------------------------------
>
>                 Key: MRELEASE-386
>                 URL: http://jira.codehaus.org/browse/MRELEASE-386
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>    Affects Versions: 2.0-beta-8
>         Environment: n/a
>            Reporter: Anders Hammar
>         Attachments: MRELEASE-386-patch.diff
>
>
> While browsing the code I saw this sneaky bug in DefaultReleaseManager (note that the
clean parameter value is ignored):
> {noformat}
>     public void perform( ReleaseDescriptor releaseDescriptor, ReleaseEnvironment releaseEnvironment,
List reactorProjects, boolean clean )
>         throws ReleaseExecutionException, ReleaseFailureException
>     {
>         perform( releaseDescriptor, releaseEnvironment, reactorProjects, null, false
);
>     }
> {noformat}
> This method is only used once within the release plugin and it that case the clean parameter
value is then always 'false', so this is not yet an issue when using the plugin.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message