Return-Path: 
 <issues-return-37937-apmail-maven-issues-archive=maven.apache.org@maven.apache.org>
Delivered-To: apmail-maven-issues-archive@locus.apache.org
Received: (qmail 91327 invoked from network); 21 Mar 2008 16:06:18 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 21 Mar 2008 16:06:17 -0000
Received: (qmail 30035 invoked by uid 500); 21 Mar 2008 16:06:15 -0000
Delivered-To: apmail-maven-issues-archive@maven.apache.org
Received: (qmail 29994 invoked by uid 500); 21 Mar 2008 16:06:15 -0000
Mailing-List: contact issues-help@maven.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@maven.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@maven.apache.org>
List-Post: <mailto:issues@maven.apache.org>
List-Id: <issues.maven.apache.org>
Reply-To: dev@maven.apache.org
Delivered-To: mailing list issues@maven.apache.org
Received: (qmail 29983 invoked by uid 99); 21 Mar 2008 16:06:15 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Mar 2008 09:06:15 -0700
X-ASF-Spam-Status: No, hits=-0.0 required=10.0
	tests=SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (athena.apache.org: local policy)
Received: from [63.246.2.115] (HELO codehaus01.managed.contegix.com)
 (63.246.2.115)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Mar 2008 16:05:37 +0000
Received: from codehaus01.managed.contegix.com (localhost.localdomain
 [127.0.0.1])
	by codehaus01.managed.contegix.com (Postfix) with ESMTP id EABD614A8038
	for <issues@maven.apache.org>; Fri, 21 Mar 2008 11:05:47 -0500 (CDT)
Message-ID: 
 <31292544.1206115546674.JavaMail.haus-jira@codehaus01.managed.contegix.com>
Date: Fri, 21 Mar 2008 11:05:46 -0500 (CDT)
From: "John Casey (JIRA)" <jira@codehaus.org>
To: issues@maven.apache.org
Subject: [jira] Closed: (MNG-3426) regression : <dependency> in plugin
 configuration doesn't override plugin classpath
In-Reply-To: 
 <13366032.1204484548185.JavaMail.haus-jira@codehaus01.managed.contegix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org


     [ http://jira.codehaus.org/browse/MNG-3426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Casey closed MNG-3426.
---------------------------

      Assignee: John Casey  (was: nicolas de loof)
    Resolution: Fixed

The move to use LinkedHashSet was definitely correct IMO, but it led to some weird side effects for dependency ordering. I've gone back and added a pre-processing step using a LinkedHashMap to merge in the plugin-level dependencies and those from the plugin-POM itself. I kept the plugin-level deps as first to be added, which gives them precedence (so they can replace dependencies from the plugin POM), but added code to make sure any duplicates according to dependencyConflictId are avoided. This is consistent with dependencies in the POM, where duplicates there should lead to a model validation exception during project building.

I think this issue can safely be put to bed now.

> regression : <dependency> in plugin configuration doesn't override plugin classpath
> -----------------------------------------------------------------------------------
>
>                 Key: MNG-3426
>                 URL: http://jira.codehaus.org/browse/MNG-3426
>             Project: Maven 2
>          Issue Type: Bug
>          Components: Plugin API
>    Affects Versions: 2.0.8
>            Reporter: nicolas de loof
>            Assignee: John Casey
>            Priority: Critical
>             Fix For: 2.0.9
>
>
> Many maven plugins are wrapper around other tools. The plugin is designed for a version of the tool, and in many case user will want to use a specific version without having to patch the plugin. The <dependency> element on plugin configuration is a common way to do this, by overriding the plugin POM dependency with another version. 
> <plugin>
>    <artifactId>castor-maven-plugin</artifactId>
>    <dependencies>
>        <dependency>
>             <groupId>org.codehaus.castor</groupId>
>             <artifactId>castor</artifactId>
>             <version>VERSION OF CASTOR I WANT TO USE FOR CODE GENERATION</version>
>        </dependency>
>    </dependencies>
> </plugin>
> This used to work with maven < 2.0.8
> In maven 2.0.8, this doesn't work anymore as the <dependency> set in plugin configuration is added to plugin classpath, as a duplicate for the one declared by the plugin but LATER in the classpath (but I may be wrong on this analysis).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira