maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vincent Siveton (JIRA)" <j...@codehaus.org>
Subject [jira] Commented: (MPIR-85) Refactoring of dependency and dependency management report
Date Tue, 04 Mar 2008 23:45:28 GMT

    [ http://jira.codehaus.org/browse/MPIR-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_126065
] 

Vincent Siveton commented on MPIR-85:
-------------------------------------

IMHO it is a good work. Thanks!

I have some comments on the code:
* I dont like AbstractDependencies#getScope(Object) Why not using getScope() directly ?
*  could you provide some test cases for new comparator classes?

Some comments on the Maven code convention:
* we don't use final at all, specially in methods definition/signature
* could you separated public/protected/private in each class to make the code more readingness?
* could you comment a minimum with javadoc, specially abstract classes? Btw it is $Id: $ (with
colon) for the @version tag

I think you could go ahead.

> Refactoring of dependency and dependency management report
> ----------------------------------------------------------
>
>                 Key: MPIR-85
>                 URL: http://jira.codehaus.org/browse/MPIR-85
>             Project: Maven 2.x Project Info Reports Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.1
>            Reporter: Nick Stolwijk
>         Attachments: refactor.patch
>
>
> I've tried to refactor the code from MPIR-83 a bit, because it used a lot of copied code.
> Important improvements:
> - Created a AbstractProjectInfoRenderer and AbstractDependencyRenderer.
> If this patch is accepted, I want to write all the renderers out of the inforeports in
separate classes, with more code sharing. This is a start of that.
> - I changed the unit tests, because the expected and actual were reversed. This is the
case in many of the info report unit tests.
> Please tell me what you think of it. I know it is only a start.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message