maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Duncan Doyle (JIRA)" <j...@codehaus.org>
Subject [jira] Issue Comment Edited: (SCM-342) scm:tag should support flat project layout
Date Fri, 14 Dec 2007 00:17:57 GMT

    [ http://jira.codehaus.org/browse/SCM-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_116760
] 

mccloud edited comment on SCM-342 at 12/13/07 6:16 PM:
------------------------------------------------------------

Patch to support to tag flat project layouts.

This patch provides support for flat project layouts. I've enabled the @aggregator Maven option
to process multiple modules. Furthermore. it basically keeps track of all the ScmFileSet basedirectories
which have been processed in a static HashSet. Before a new fileset is tagged, it checks that
the ScmFileSet has not already been processed. Next it checks that the current ScmFileSet
is not a sub-directory of an already processed basedir. If that's all true, the fileset is
tagged and its basedir is added to the static HashSet..

This solution works in both a standard Maven2 layout (i.e. not tagging sub-projects twice
because it keeps track of already processed basedirs) and a flat layout (i.e. because the
@aggregator option is used).

      was (Author: mccloud):
    Patch to support to tag flat project layouts.
  
> scm:tag should support flat project layout
> ------------------------------------------
>
>                 Key: SCM-342
>                 URL: http://jira.codehaus.org/browse/SCM-342
>             Project: Maven SCM
>          Issue Type: Bug
>          Components: maven-plugin
>    Affects Versions: 1.0
>         Environment: Windows XP, Eclipse 3.3
>            Reporter: Duncan Doyle
>         Attachments: flatProjectTagPatch.txt
>
>
> I have a Maven2 Flat Project Layout as described here: http://maven.apache.org/guides/mini/guide-ide-eclipse.html
> Basically my directory layout is as follows:
> /MavenRoot/pom.xml  (this is the SuperPom)
> /Module1/pom.xml
> /Module2/pom.xml
> /Module3/pom.xml
> Modules 1,2 and 3 are specified in the <modules> section of the SuperPom (e.g()
<module>../Module1</module>). Each POM contains its own CVS connection URL.
> When I execute the scm:tag goal on the SuperPom in the MavenRoot project, only the MavenRoot
project gets tagged. The same behaviour can be seen with the scm:update goal, which was fixed
by providing a scm:update-subprojects goal.
> I would like to see this behaviour fixed in the SCM plugin, while Maven2 advices a Flat
Project Layout when working with Eclipse. At this moment I can't use the tag goal at all (it
should be executed automatically by CruiseControl on a succesfull build).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message