maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Onis (JIRA)" <j...@codehaus.org>
Subject [jira] Commented: (MECLIPSE-78) create eclipse projects which are m2eclipse ready
Date Mon, 12 Feb 2007 08:12:23 GMT

    [ http://jira.codehaus.org/browse/MECLIPSE-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_87342
] 

Martin Onis commented on MECLIPSE-78:
-------------------------------------

Rob,

Yes the child POMs reference back to their parent (by both groupId/artifactId/version and
by relativePath).

Point 2 is not something I have a problem with. By removing the manual configuration of th
classpath I effectively negated it's effect. I just thought you would want to know that it's
there :) The other configuration items only showed up once, so no problem there.

The main problem I have is that the plugin sees the configured {{m2eclipse}} flag only at
the root POM level. If I add a println of the value in the plugin where it is queried in the
code, I can see its value being false for all child POMs. This is true wether I use the mvn
command from the root POM directory or from a child POM directory. The {{downloadSources}}
flag however is seen throughout the POM tree.
This is the reason I 'patched your patch' ;-) locally, so it's hardwired to true (the configuration
item in my POM now only serves as a reminder).

I'm sure that by the time they they push this fix into the project someone will check the
code and fix the configuration issue (I'm confused myself about how to fix that).

> create eclipse projects which are m2eclipse ready
> -------------------------------------------------
>
>                 Key: MECLIPSE-78
>                 URL: http://jira.codehaus.org/browse/MECLIPSE-78
>             Project: Maven 2.x Eclipse Plugin
>          Issue Type: New Feature
>         Environment: Fedora Core 3, Sun JDK 1.5.0.06, Eclipse 3.1.1, Maven 2.0.2
>            Reporter: Joshua Nichols
>         Attachments: m2eclipse-add-repo-tag-2.3.patch, m2eclipse-add-repo.patch, m2eclipse.patch,
m2eclipse.patch, m2eclipse.patch, m2eclipse.patch, MECLIPSE-78-tag-2.3-rev2.patch, MECLIPSE-78-tag-2.3.patch,
MECLIPSE-78.patch
>
>
> WIth the recent development of the m2eclipse plugin, I believe it is useful to create
eclipse projects via mvn eclipse:eclipse that use m2eclipse from the start. One of the advantages
of using m2eclipse is that you don't have to rerun eclipse:eclipse when you update any dependencies.
> A few things are necessary to accomplish this, in terms of changes to .classpath and
.project.
> .project needs a new nature and builder added. For the builder:
>     <buildCommand>
>       <name>org.maven.ide.eclipse.maven2Builder</name>
>       <arguments/>
>     </buildCommand>
> For the nature:
> <nature>org.maven.ide.eclipse.maven2Nature</nature>
> In the .classpath, we need to add:
>   <classpathentry kind="con" path="org.maven.ide.eclipse.MAVEN2_CLASSPATH_CONTAINER"/>
> In .classpath, you also don't want entries <classpathentry kind="var" path="M2_REPO/blah/blah/x.y.z/blah-x.y.z.jar"/>,
because they would conflict with m2eclipse setting up the classpath.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message